Merge lp:~jtv/launchpad/db-bug-790084 into lp:launchpad/db-devel
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 10622 |
Proposed branch: | lp:~jtv/launchpad/db-bug-790084 |
Merge into: | lp:launchpad/db-devel |
Diff against target: |
69 lines (+19/-1) 3 files modified
lib/lp/registry/interfaces/distroseriesdifference.py (+3/-0) lib/lp/soyuz/model/packagecopyjob.py (+6/-1) lib/lp/soyuz/tests/test_packagecopyjob.py (+10/-0) |
To merge this branch: | bzr merge lp:~jtv/launchpad/db-bug-790084 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Henning Eggers (community) | Approve | ||
Review via email: mp+62845@code.launchpad.net |
Commit message
[r=henninge][bug=790084] Attach package sync error only to the right DSD.
Description of the change
= Summary =
When an asynchronous package copy requested from a DistroSeriesDif
== Proposed fix ==
I neglected to filter the DSDs by source package name. Easy fix.
== Pre-implementation notes ==
Failed to have one. I'm bad.
== Implementation details ==
I had to add IDistroSeriesDi
== Tests ==
{{{
./bin/test -vvc lp.soyuz.
}}}
== Demo and Q/A ==
Request an asynchronous sync that will fail with a CannotCopy exception. Presently amsn is a usable example. Make sure that cronscripts/
{{{
./cronscripts/
}}}
The failure should leave a note on its DSD entry on +localpackagediffs, but not on the entries for other packages.
= Launchpad lint =
Oops, I missed a spot which I shall fix forthwith:
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
423: local variable 'other_dsd' is assigned to but never used
Thanks. ;-)