Merge lp:~jtv/launchpad/db-bug-752181 into lp:launchpad/db-devel
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 10409 |
Proposed branch: | lp:~jtv/launchpad/db-bug-752181 |
Merge into: | lp:launchpad/db-devel |
Diff against target: |
67 lines (+12/-6) 4 files modified
cronscripts/publishing/distro-parts/ubuntu/publish-distro.d/30-copy-indices (+3/-2) cronscripts/publishing/distro-parts/ubuntu/publish-distro.d/README.txt (+3/-0) lib/lp/archivepublisher/scripts/publish_ftpmaster.py (+2/-1) lib/lp/archivepublisher/tests/test_publish_ftpmaster.py (+4/-3) |
To merge this branch: | bzr merge lp:~jtv/launchpad/db-bug-752181 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+56903@code.launchpad.net |
Commit message
[r=adeuring][bug=752181] Pass OVERRIDEROOT to publish-distro plugins.
Description of the change
= Summary =
In replacing the system-specific and distro-specific parts of the cron.publish-
== Proposed fix ==
Take OVERRIDEROOT from the archive-
== Pre-implementation notes ==
William notes that the indices directory may not exist yet. So I changed the plugin script to create it if necessary.
== Implementation details ==
I was careless in my unit-testing of the new python-based publish-ftpmaster script. The two tests for parameters being passed to the plugin scripts would fail if I passed too many, but not if I passed too few (which is what really needs testing). Proper TDD would have shown me this as I ran the test before implementing the feature. That wasn't really feasible for such a large and radical branch though; in retrospect it might have been possible to break it down into smaller branches somehow.
== Tests ==
{{{
./bin/test lp.archivepubli
}}}
== Demo and Q/A ==
We run publish-ftpmaster on dogfood and watch for error output or missing results.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
cronscripts/
cronscripts/
lib/lp/
lib/lp/