Merge lp:~jtv/launchpad/bug-894690 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jeroen T. Vermeulen | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 14391 | ||||
Proposed branch: | lp:~jtv/launchpad/bug-894690 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
28 lines (+4/-3) 1 file modified
lib/lp/translations/javascript/importqueue.js (+4/-3) |
||||
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-894690 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Badin (community) | Approve | ||
Review via email:
|
Commit message
[r=rvb][bug=894690] Restored vanished status field on translations import queue pages.
Description of the change
= Summary =
The entry-status field (including selector, if appropriate) went missing on the translations import queue pages. We need these fields!
== Proposed fix ==
The cause was a change that replaced a style="
Now that the field is hidden by a class instead of a style attribute, it should be revealed through a removeClass(
== Pre-implementation notes ==
Raphaël followed my reasoning. I didn't consult anyone on the fix as such.
This kind of bug is surprisingly hard to test for. Even if the authors of the code could have seen the change coming, it's hard to catch: a full-blown python/
== Implementation details ==
I also fixed a bit of lint, where a comparison was done as “==” instead of the seemingly more appropriate “===”.
== Tests ==
You've got me there. How does one test this effectively? I tried setting up a new unit test, to at least test that the function now removes the "hidden" attribute if it's there. But I found myself unable to get it to work, as well as unable to pinpoint the failure in the debugger (although I did get to see a nice firefox crash). And yet the clock is ticking while users are hindered in their work.
So, with reluctance and self-loathing, I offer no test for this change. I'm sorry; I have failed you.
== Demo and Q/A ==
Go to any of the translations import queue pages, such as:
https:/
(Or similar on dev, which is what I did, or elsewhere.)
The right-hand side of the page should show the status of each entry — Approved, Needs Review, Blocked, Imported, Failed, or Needs Information. This column is currently missing.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
Looks good :)