Merge lp:~jtv/launchpad/bug-887063 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 14265 | ||||
Proposed branch: | lp:~jtv/launchpad/bug-887063 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
23 lines (+2/-4) 1 file modified
lib/lp/translations/model/translationpackagingjob.py (+2/-4) |
||||
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-887063 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij (community) | Approve | ||
Review via email: mp+81439@code.launchpad.net |
Commit message
Log noise: packaging_
Description of the change
= Summary =
We're getting some silly log noise from packaging_
== Proposed fix ==
Downgrade to info. We want the error-reports list to be quiet yet interesting. Launchpad not hosting translations for Lenny is not very interesting.
== Pre-implementation notes ==
I asked on #launchpad-dev. No reactions. Silence is assent.
== Implementation details ==
The warning string doesn't seem to occur in any tests (although I am of course running an EC2 test to make sure). So I don't expect to break any.
We don't usually test for log output anyway, but there were times when it was often our easiest way to establish what a script-related class was doing — especially in doctests. Hence always worth checking for.
== Tests ==
At least one pre-existing test covers this code path:
{{{
./bin/test -vvc lp.translations
}}}
== Demo and Q/A ==
Run the job; watch it not break.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/