Merge lp:~jtv/launchpad/bug-834388 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Данило Шеган | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 13868 | ||||
Proposed branch: | lp:~jtv/launchpad/bug-834388 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
173 lines (+32/-45) 4 files modified
lib/lp/soyuz/interfaces/publishing.py (+8/-1) lib/lp/soyuz/model/publishing.py (+14/-25) lib/lp/soyuz/scripts/ftpmaster.py (+10/-11) lib/lp/soyuz/tests/test_publishing.py (+0/-8) |
||||
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-834388 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Approve | ||
Review via email: mp+73483@code.launchpad.net |
Commit message
[r=danilo][bug=834388] Don't bypass ORM in IPublishingSet.
Description of the change
= Summary =
IPublishingSet.
== Proposed fix ==
Use storm.ResultSet
== Pre-implementation notes ==
Suggested by wgrant; I wasn't aware of storm.ResultSet
== Implementation details ==
A lot of the diff is in ftpmaster.py. It goes through some contortions to delete [SB]PPHs one by one, when the normal case is actually ideally suited for mass deletions. I changed that, but in a roundabout way: I now need to filter the BPPHs out of the list of removables after first gathering them for no better reason than to maintain logging output.
Still, I hope it's a first step towards moving even more of this into IPublishingSet.
== Tests ==
{{{
./bin/test lp.soyuz.
./bin/test lp.soyuz -t ftpmaster
}}}
== Demo and Q/A ==
Archive deletion must still work, and mark publication records as deleted.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
Assuming all is well tested and you watch for performance degradation, all is fine.