Merge lp:~jtv/launchpad/bug-818032 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jeroen T. Vermeulen | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 13563 | ||||
Proposed branch: | lp:~jtv/launchpad/bug-818032 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
83 lines (+16/-5) 3 files modified
lib/lp/registry/browser/distroseries.py (+1/-1) lib/lp/registry/browser/tests/test_distroseries.py (+11/-4) lib/lp/services/features/flags.py (+4/-0) |
||||
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-818032 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+69791@code.launchpad.net |
Commit message
[r=bac][bug=818032] Disable Upgrade Packages button.
Description of the change
= Summary =
Disable the Upgrade Packages button for now. It's too dangerous and, in a few nasty corner cases, does not do what we want.
== Proposed fix ==
The mass-upgrade is behind the same feature flag as package sync. The flag name mentions "sync" but not "upgrade." Give the mass upgrade its own feature flag, which will be disabled by default.
== Pre-implementation notes ==
We may still want to enable the button for derived distributions later; for now, we can't have it in Ubuntu. Removing the code (as I originally wanted to do) would cut pretty deep, and dispose of things we hope the able to use again.
== Tests ==
{{{
./bin/test -vvc lp.registry.
}}}
== Demo and Q/A ==
The DistroSeries:
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
This change looks good Jeroen.