Merge lp:~jtv/launchpad/bug-812667 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13667 |
Proposed branch: | lp:~jtv/launchpad/bug-812667 |
Merge into: | lp:launchpad |
Diff against target: |
48 lines (+5/-5) 3 files modified
lib/lp/registry/stories/distroseries/xx-distroseries-index.txt (+1/-1) lib/lp/registry/templates/distribution-series.pt (+1/-1) lib/lp/registry/templates/distroseries-details.pt (+3/-3) |
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-812667 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+71157@code.launchpad.net |
Commit message
[r=jtv][bug=812667] Don't say a distroseries "derives from" its previous_series.
Description of the change
= Summary =
The DistroSeries listings still say that a series "derives from" its previous_series. But distro derivation now assigns a very specific meaning to that term that has nothing to do with previous_series.
== Proposed fix ==
Say "successor to" instead of "derives from."
== Pre-implementation notes ==
StevenK did not like this wording: it "doesn't really do it for" him. Alternatives that have been considered:
* "Based on" — too generic, would cover derivation just as well.
* "Previous release" — in this context, makes it look like a previous release _of the series_.
* "Supersede" — but is that always accurate?
We do need to get away from "derives from," however.
== Implementation details ==
We may still choose to change the wording. It's pretty much a copy-paste job to this branch. There is one other place where the wording will be affected once we retire the feature flag for the distro-derivation UI.
== Tests ==
{{{
./bin/test lp.registry -t xx-distroseries
}}}
== Demo and Q/A ==
Browse to /ubuntu/+series and look at the series descriptions. There should now be a clear, sensible distinction between succession and derivation.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
(17:51:14) bigjools: jtv: I am +1 on successor
(17:51:22) jtv: Great, thanks.
(17:51:24) bigjools: just self-review your branch and land it
(17:51:29) jtv: OK