Merge lp:~jtv/launchpad/bug-798179 into lp:launchpad

[Jeroen T. Vermeulen]

[r=allenap][bug=798179] Support changefile-less PackageUploads on +queue.

= Summary =

The Distroseries:+queue page breaks when displaying a PackageUpload without changes file attached, as might be the case with a PackageCopyJob upload.

== Proposed fix ==

I don't have time to clean up the TAL and move the logic into view code. Instead, I just add some safety checks around the breaking tags.

== Pre-implementation notes ==

Julian would love me to move logic from TAL into view code, but I find there's no view for the individual PackageUpload lines. I'd have to create one, and I've bitten off too much of this work to chew already. Maybe later!

== Implementation details ==

There was an import missing. No idea how that got through; I'm juggling a number of branches at the moment and I'll search them for the origin of this problem and if possible, fix it at the source.

== Tests ==

{{{
./bin/test -vvc lp.soyuz.browser.tests.test_queue
}}}

== Demo and Q/A ==

Create a PackageUpload with a PackageCopyJob but nothing else attached, and view it in the UI. It should display something sensible: package name as the name, no link to any changes file, no oops.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/soyuz/browser/tests/test_queue.py
  lib/lp/soyuz/templates/distroseries-queue.pt
  lib/lp/soyuz/model/packagecopyjob.py

[Gavin Panella (allenap)]

Tip top :)

review: Approve