Merge lp:~jtv/launchpad/bug-739986 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12644 |
Proposed branch: | lp:~jtv/launchpad/bug-739986 |
Merge into: | lp:launchpad |
Diff against target: |
73 lines (+15/-10) 3 files modified
lib/lp/services/features/__init__.py (+7/-5) lib/lp/services/scripts/base.py (+1/-2) lib/lp/services/scripts/tests/test_feature_controller.py (+7/-3) |
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-739986 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Kowalik (community) | Approve | ||
Review via email: mp+54299@code.launchpad.net |
Commit message
[r=stevenk][bug=739986] Script feature controller wasn't installing properly.
Description of the change
= Summary =
The script feature controller wasn't being set up due to a last-minute API change.
make_script_
== Proposed fix ==
Return a feature controller from make_script_
== Pre-implementation notes ==
I wholeheartedly apologize for the pain this caused StevenK.
== Implementation details ==
The way LaunchpadScript installs its feature controller had changed a bit at the last moment. It used to do that in the constructor, but because some scripts' "name" property isn't callable yet at that point, I've made it internal to "run." Which probably makes more sense anyway, except that I neglected to call "run" in the relevant test.
In the script test I added a check that the observed feature controller really is a FeatureController. That's not necessary to detect the actual bug (the test will fail before then, once we remember to call run()) but it would have helped spot the mistake of not calling run.
== Tests ==
{{{
./bin/test -vvc lp.services.
}}}
== Demo and Q/A ==
Steve will be able to observe the difference in his ongoing work.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/