Merge lp:~jtv/launchpad/bug-723733 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jeroen T. Vermeulen | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12451 | ||||
Proposed branch: | lp:~jtv/launchpad/bug-723733 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
72 lines (+13/-11) 1 file modified
lib/devscripts/ec2test/builtins.py (+13/-11) |
||||
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-723733 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Approve | ||
Review via email: mp+50935@code.launchpad.net |
Commit message
[r=abentley]
Description of the change
= Summary =
To update the AMI image, as per https:/
== Proposed fix ==
The code for "ec2 update-image" already clears the LC_ALL and LANG variables for the same reason. It should drop LC_TIME as well.
== Pre-implementation notes ==
Julian agrees.
== Implementation details ==
I also encapsulated various pdb.set_trace() calls into a single method. Each of those calls was reported as lint, and now there's only one left. Not perfect, but perhaps better than suppressing warnings and repeating the same iffy pattern all over the place.
The function's name looks a little unusual, but I think best says "call set_trace if this variable is True" without requiring the reader to look up what it does.
== Tests ==
Ahem. All I can think of is: run the image.
== Demo and Q/A ==
Run the "ec2 update-image" command line from https:/
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/devscript
./lib/devscript
153: Line contains a call to pdb.