Merge lp:~jtv/launchpad/bug-643240 into lp:launchpad

Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Robert Collins
Approved revision: no longer in the source branch.
Merged at revision: 11577
Proposed branch: lp:~jtv/launchpad/bug-643240
Merge into: lp:launchpad
Diff against target: 24 lines (+3/-4)
1 file modified
lib/lp/translations/stories/translations/30-rosetta-pofile-translation-gettext-error.txt (+3/-4)
To merge this branch: bzr merge lp:~jtv/launchpad/bug-643240
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Launchpad code reviewers code Pending
Review via email: mp+35984@code.launchpad.net

Commit message

Fix broken stories test on maverick.

Description of the change

= Bug 643240 =

A pagetest was breaking on Maverick due to an apparent change in how gettext reports an inconsistency between format specificiers ("%s" and such) between both msgids (singular and plural) on the one hand, and the translations on the other.

Since the exact text of the error message isn't relevant to the pagetest, I just replaced the changed part with "…"; but I left in most of the text since it still provides helpful context for reading the test.

To test,
{{{
./bin/test -vvc -m lp.translations -t stories/translations
}}}

(You really only need to wait for the first of these tests to pass though; the others are unaffected).

Jeroen

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

doit

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/translations/stories/translations/30-rosetta-pofile-translation-gettext-error.txt'
2--- lib/lp/translations/stories/translations/30-rosetta-pofile-translation-gettext-error.txt 2007-09-14 18:12:05 +0000
3+++ lib/lp/translations/stories/translations/30-rosetta-pofile-translation-gettext-error.txt 2010-09-20 05:51:38 +0000
4@@ -42,8 +42,7 @@
5 ... u'Found %s invalid files')
6 >>> user_browser.getControl(name='submit_translations').click()
7
8-We got an error, that means the url should be the same.
9-We are still in the same URL, because the system detected an error.
10+Because of the error, we're still in on the same page.
11
12 >>> print user_browser.url
13 http://translations.launchpad.dev/ubuntu/hoary/+source/evolution/+pots/evolution-2.2/es/+translate?start=20
14@@ -61,8 +60,8 @@
15 <td>
16 </td><td>
17 <div>
18- format specifications in 'msgid' and 'msgstr[0]' for argument 1 are
19- not the sameformat specifications in 'msgid' and 'msgstr[1]' for
20+ format specifications in ... and 'msgstr[0]' for argument 1 are
21+ not the sameformat specifications in ... and 'msgstr[1]' for
22 argument 1 are not the same
23 </div>
24 </td>