Merge lp:~jtv/launchpad/bug-553077 into lp:launchpad
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Jelmer Vernooij on 2010-04-01 | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp:~jtv/launchpad/bug-553077 | ||||
| Merge into: | lp:launchpad | ||||
| Diff against target: |
12 lines (+1/-1) 1 file modified
lib/canonical/buildd/debian/control (+1/-1) |
||||
| To merge this branch: | bzr merge lp:~jtv/launchpad/bug-553077 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Nelson (community) | code | 2010-04-01 | Approve on 2010-04-01 |
| Jelmer Vernooij (community) | code* | 2010-04-01 | Approve on 2010-04-01 |
|
Review via email:
|
|||
Commit Message
Tighten launchpad-buildd dependencies; avoid depending on universe.
Description of the Change
= Bug 553077 =
It'd be nice to get this reviewed today, 2010-04-01; PQM is closed but there's a launchpad-buildd coming up that doesn't require this to be in devel.
The launchpad-buildd package, which we install on the virtualized build slaves, depended on python-twisted. The dependencies behind that were extended recently to include, through python-
Luckily there is no need to pull in the entire python-twisted metapackage (thanks wgrant for pointing this out). Just python-twisted-core and python-twisted-web turned out to be enough.
We grep'ed for any imports from twisted in the code. These were the modules in actual use:
twisted.
twisted.internet
twisted.python
twisted.web
Of these, twisted.web is the only one that isn't in core. So in this branch I replace the python-twisted dependency with python-twisted-core plus python-twisted-web. There's also an import of twisted.mail.smtp, but that's in a file that is no longer in use. William has a cleanup campaign planned.
I can't think of a way to test this in the automated test suite, but following the steps at https:/
Jeroen
| Michael Nelson (michael.nelson) wrote : | # |
> Thanks, less dependencies ftw.
>
> It would also be nice to clean up some of the warnings in the package (using
> an old policy version, old (deprecated) debhelper etc) at some point.
>
> I'm curious, is there any reason for the buildd slave code being inside of the
> main tree ? It seems like it could easily be moved into its own independent
> (more manageable) branch.
That's bug 547036. Thanks Jelmer and Jeroen.
Thanks, less dependencies ftw.
It would also be nice to clean up some of the warnings in the package (using an old policy version, old (deprecated) debhelper etc) at some point.
I'm curious, is there any reason for the buildd slave code being inside of the main tree ? It seems like it could easily be moved into its own independent (more manageable) branch.