Merge lp:~jtv/launchpad/bug-520659 into lp:launchpad

[Jeroen T. Vermeulen]

Fix import-queue edit icons for webkit.

[Jeroen T. Vermeulen (jtv)]

= Bug 520659 =

Curtis Hovey noted that webkit-based browser do not show the "edit" icons for translation import queue entries.

He also found the solution: there's a <span class="hidden-link"> inside the link, and an obscure snag in our CSS makes this work only when the span tag abuts the anchor tag, without any intervening whitespace.

Before: http://people.canonical.com/~jtv/bug-520659/before.png
After: http://people.canonical.com/~jtv/bug-520659/after.png

(The icons still won't show up in Konqueror because of a separate problem with the edit sprites. That's being resolved as well.)

No tests. No lint. Q/A by comparing the page between Chromium and Firefox, on edge and production.

Jeroen

[Jeroen T. Vermeulen (jtv)]

sinzui just gave his approval on IRC.

review: Approve (code)

[Curtis Hovey (sinzui)]

I did give approval.

review: Approve

=== modified file 'lib/lp/translations/templates/translation-import-queue-macros.pt'
--- lib/lp/translations/templates/translation-import-queue-macros.pt	2009-12-03 18:33:22 +0000
+++ lib/lp/translations/templates/translation-import-queue-macros.pt	2010-02-11 21:04:20 +0000
@@ -160,10 +160,14 @@
                       No import target selected yet.
                     </span>
                     <tal:block condition="entry/required:launchpad.Admin">
+                      <tal:comment condition="nothing">
+                        Our CSS requires the span to abut the "a" tag, with no
+                        intervening whitespace.  If the two are separated, the
+                        edit links stop showing up in Webkit.
+                      </tal:comment>
                       <a class="sprite edit"
-                         tal:attributes="href entry/fmt:url">
-                        <span class="invisible-link">Change this entry</span>
-                      </a>
+                         tal:attributes="href entry/fmt:url"
+                         ><span class="invisible-link">Change this entry</span></a>
                     </tal:block>
                   </td>
                 </tr>