Merge lp:~jtv/launchpad/bug-463097 into lp:launchpad

[Jeroen T. Vermeulen]

[Jeroen T. Vermeulen (jtv)]

= Oops config tweaks for poimport =

This branch is attached to bug 463097, but is not its solution. The actual production config that's needed to make my oopses work needs to go into a separate branch, not the code branches.

These tweaks don't matter much; they're mainly here to validate the documentation on oops logging that I started at https://dev.launchpad.net/LoggingOopses

To test:
{{{
./bin/test -vv -t 'translations.*import'
}}}

This successfully generates oops reports in {{{/var/tmp/poimport.test}}}, as before. I found no lint, and since this affects tests and local runs only (and the latter only in the naming of a directory of no further consequence), there's no Q/A plan either.

Jeroen

[Michael Nelson (michael.nelson)]

Hi Jeroen,

The tweak here adding the error_dir to the development conf looks fine - I'm a little confused as to why the testrunner config was the wrong place for the error_dir when running tests, but as you said, the oopses are correctly generated when running the tests with the development error_dir.

review: Approve (code)

[Jeroen T. Vermeulen (jtv)]

BjornT feels it's probably better to have oopses from test runs and ones from local runs separate.

review: Disapprove

=== modified file 'configs/development/launchpad-lazr.conf'
--- configs/development/launchpad-lazr.conf	2009-10-29 05:50:08 +0000
+++ configs/development/launchpad-lazr.conf	2009-10-29 07:05:28 +0000
@@ -204,7 +204,7 @@
 oops_prefix: RSBR
 
 [poimport]
-error_dir: /var/tmp/poimport
+error_dir: /var/tmp/poimport.test
 oops_prefix: POI
 
 [supermirror_puller]

=== modified file 'configs/testrunner/launchpad-lazr.conf'
--- configs/testrunner/launchpad-lazr.conf	2009-10-23 18:00:45 +0000
+++ configs/testrunner/launchpad-lazr.conf	2009-10-29 07:05:28 +0000
@@ -171,7 +171,6 @@
 root: /var/tmp/ppa.test/
 
 [poimport]
-error_dir: /var/tmp/poimport.test
 oops_prefix: TPOI
 
 [rosettabranches]