Merge lp:~jtv/launchpad/bug-433989 into lp:launchpad
Proposed by
Jeroen T. Vermeulen
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jeroen T. Vermeulen | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~jtv/launchpad/bug-433989 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
97 lines 4 files modified
lib/lp/translations/browser/configure.zcml (+0/-1) lib/lp/translations/browser/language.py (+3/-12) lib/lp/translations/browser/translationgroup.py (+6/-0) lib/lp/translations/browser/translator.py (+5/-6) |
||||
To merge this branch: | bzr merge lp:~jtv/launchpad/bug-433989 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Eleanor Berger (community) | Approve | ||
Review via email: mp+12180@code.launchpad.net |
To post a comment you must log in.
= Bug 433989 =
I missed a few spots when I updated the page headings for the
TranslationGroup and Translator pages. (A Translator is really just a
membership record in a TranslationGroup).
Of these, I fixed a bad page title that still contained too much context
but left the other—a missing breadcrumb for Translator—unfixed. The
reason is that the breadcrumb would link to a page that not everyone who
saw it would have access to.
As a drive-by cleanup, this branch also removes LanguageNavigation which
became unnecessary as Salgado fixed the bug that made it necessary last
week.
To see the change, go to
https:/ /translations. launchpad. dev/+groups/ launchpad- translators/ +reassign
or
https:/ /translations. net.launchpad. net/+groups/ launchpad- translators/ +reassign
...before and after the change. The last breadcrumb should become a lot
shorter.
No lint.
Jeroen