Merge lp:~jtv/launchpad/bug-423191 into lp:launchpad

[Jeroen T. Vermeulen]

[Jeroen T. Vermeulen (jtv)]

= Bug 423191 =

When fetching random suggestions for the stuff-to-translate list, I
forgot to slice the results before feeding them into the links
aggregator. So the aggregator went through everything it could find
that you could possibly translate, which may have taken a bit longer
than necessary.

Jeroen

[Jeroen T. Vermeulen (jtv)]

Please ignore auto-generated diff. Here's what I have now:

=== modified file 'lib/lp/translations/browser/person.py'
--- lib/lp/translations/browser/person.py 2009-08-31 16:55:39 +0000
+++ lib/lp/translations/browser/person.py 2009-09-03 12:48:47 +0000
@@ -249,6 +249,9 @@
         pofiles = person.suggestTranslatableFiles(
             no_older_than=self.history_horizon)

+ if max_fetch is not None:
+ pofiles = pofiles[:max_fetch]
+
         return TranslateLinksAggregator().aggregate(pofiles)

     @cachedproperty

[Jeroen T. Vermeulen (jtv)]

Danilo's reviewing this one.

review: Abstain

[Данило Шеган (danilo)]

It'd be nice to have a test to make sure we don't miss it again, though. Basically, just create a bunch of translationmessages and make sure the list doesn't grow past that maximum.

review: Approve (code)

=== modified file 'lib/lp/translations/browser/person.py'
--- lib/lp/translations/browser/person.py	2009-08-31 16:55:39 +0000
+++ lib/lp/translations/browser/person.py	2009-09-03 12:39:13 +0000
@@ -247,7 +247,7 @@
         """Suggest translations this person could be helping complete."""
         person = ITranslationsPerson(self.context)
         pofiles = person.suggestTranslatableFiles(
-            no_older_than=self.history_horizon)
+            no_older_than=self.history_horizon)[:max_fetch]
 
         return TranslateLinksAggregator().aggregate(pofiles)