Merge lp:~jtv/launchpad/bug-299008 into lp:launchpad

Proposed by Jeroen T. Vermeulen on 2010-02-18
Status: Merged
Approved by: Jeroen T. Vermeulen on 2010-02-18
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~jtv/launchpad/bug-299008
Merge into: lp:launchpad
Diff against target: 16 lines (+4/-3)
1 file modified
lib/lp/translations/utilities/gettext_po_parser.py (+4/-3)
To merge this branch: bzr merge lp:~jtv/launchpad/bug-299008
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) code Approve on 2010-02-18
Karl Fogel (community) Approve on 2010-02-18
Review via email: mp+19628@code.launchpad.net

Commit Message

Update note about origins of gettext parser code.

To post a comment you must log in.
Jeroen T. Vermeulen (jtv) wrote :

= Bug 299008 =

Way back, our gettext parser code was apparently based on some Python code. I investigated ages ago and found that no meaningful similarity was left (and our code has changed some more since). But a comment still noted the fact.

In this branch I replace this note with one of purely historical interest. I also removed the email addresses of the python code's authors. See Karl Fogel's suggestions in the bug ticket.

No tests, no Q/A, no lint. This is a comment.

Jeroen

Karl Fogel (kfogel) wrote :

I'm not an official reviewer, so not sure this counts, but FWIW: +1 on this change.

review: Approve
Jeroen T. Vermeulen (jtv) wrote :

This doesn't affect any code, but it is within Karl's voluminous field of expertise so his word is good enough for me. 謝謝您。

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/translations/utilities/gettext_po_parser.py'
2--- lib/lp/translations/utilities/gettext_po_parser.py 2009-09-10 16:36:34 +0000
3+++ lib/lp/translations/utilities/gettext_po_parser.py 2010-02-18 16:23:15 +0000
4@@ -4,9 +4,10 @@
5 # pylint: disable-msg=W0404
6 # (Suppress warning about two datetimes being imported)
7 #
8-# Contains code from msgfmt.py (available from python source code),
9-# written by Martin v. Loewis <loewis@informatik.hu-berlin.de>
10-# changed by Christian 'Tiran' Heimes <ch@comlounge.net>
11+# Originally based on code from msgfmt.py (available from python source
12+# code), written by Martin v. Loewis and changed by Christian 'Tiran'
13+# Heimes. The code is no longer recognizably similar though, so don't
14+# blame these people for any mistakes.
15
16 __metaclass__ = type
17