Go Windows Azure Client Library

Merge lp:~jtv/gwacl/simplify into lp:gwacl

  1. simplify
  2. Merge into trunk
Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: 94
Merged at revision: 94
Proposed branch: lp:~jtv/gwacl/simplify
Merge into: lp:gwacl
Diff against target: 17 lines (+2/-3)
1 file modified
Makefile (+2/-3)
To merge this branch: bzr merge lp:~jtv/gwacl/simplify
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+160573@code.launchpad.net

Commit message

When reformatting the code, also use gofmt's "simplify" option.

Description of the change

People suggested doing this right from the start, but I wanted to give it some time first to see whether it would affect us much. So far, it hasn't. It's not making a single change to our current tree.

The change was probably not made in the best possible way, as per the TODO in the code. Can't be bothered to tweak it any further right now.

Jeroen

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2013-04-16 14:57:56 +0000
3+++ Makefile 2013-04-24 08:53:30 +0000
4@@ -10,11 +10,10 @@
5 $(RM) $(example_binaries)
6
7 # Reformat the source files to match our layout standards.
8+# This includes gofmt's "simplify" option to streamline the source code.
9+# TODO: The -s run may actually also do the regular formatting.
10 format:
11 ./utilities/format
12-
13-# Invoke gofmt's "simplify" option to streamline the source code.
14-simplify:
15 ./utilities/format -s
16
17 # Build the examples (we have no tests for them).

Subscribers

People subscribed via source and target branches