Merge lp:~jtv/gwacl/random-test-ids into lp:gwacl

[Jeroen T. Vermeulen]

Randomize test ids in the live example.

We were having trouble running the live example because at least one of the identifiers we provide (hosted-service name) must be globally unique, within all of Azure.

In this branch I randomize those examples. I also add checking for required parameters, so that you get an immediate helpful error rather than an obscure failure later on. Also, I replaced the hard-coded storage-account name with one you provide in a command-line option.

With these changes, I was able to create a virtual machine given only a management certificate, a subscription id, and a storage account.

In a later branch we'll make the live example create the storage account for you.

Jeroen

[lp:~jtv/gwacl/random-test-ids]

53. By Jeroen T. Vermeulen on 2013-03-22

Merge trunk, resolve import conflict.

[Gavin Panella (allenap)]

review: Approve

=== modified file 'example/live_example_managementapi.go'
--- example/live_example_managementapi.go	2013-03-22 02:26:53 +0000
+++ example/live_example_managementapi.go	2013-03-22 05:37:20 +0000
@@ -13,18 +13,34 @@
     "flag"
     "fmt"
     "launchpad.net/gwacl"
+    "math/rand"
+    "os"
     "time"
 )
 
 var certFile string
+var storageAccount string
 var subscriptionID string
 var verbose bool
 
-func getParams() {
-    flag.StringVar(&certFile, "cert", "my-azure.pem", "Name of your management certificate file (in PEM format)")
-    flag.StringVar(&subscriptionID, "subscriptionid", "", "Your Azure subscription ID")
+func getParams() error {
+    flag.StringVar(&certFile, "cert", "", "Name of your management certificate file (in PEM format).")
+    flag.StringVar(&storageAccount, "storageaccount", "", "Name of a storage account where the program can create a test disk.")
+    flag.StringVar(&subscriptionID, "subscriptionid", "", "Your Azure subscription ID.")
     flag.BoolVar(&verbose, "verbose", false, "Print debugging output")
+
     flag.Parse()
+
+    if certFile == "" {
+        return fmt.Errorf("No .pem certificate specified.  Use the -cert option.")
+    }
+    if storageAccount == "" {
+        return fmt.Errorf("No storage account specified.  Use the -storageaccount option.")
+    }
+    if subscriptionID == "" {
+        return fmt.Errorf("No subscription ID specified.  Use the -subscriptionid option.")
+    }
+    return nil
 }
 
 func checkError(err error) {
@@ -33,8 +49,33 @@
     }
 }
 
+// makeRandomIdentifier creates an arbitrary identifier of the given length,
+// consisting of only ASCII digits and lower-case ASCII letters.
+// The identifier will start with the given prefix.  The prefix must be no
+// longer than the specified length, or there'll be trouble.
+func makeRandomIdentifier(prefix string, length int) string {
+    // Only digits and lower-case ASCII letters are accepted.
+    const chars = "abcdefghijklmnopqrstuvwxyz0123456789"
+
+    if len(prefix) > length {
+        panic(fmt.Errorf("prefix '%s' is more than the requested %d characters long", prefix, length))
+    }
+
+    id := prefix
+    for len(id) < length {
+        id += string(chars[rand.Intn(len(chars))])
+    }
+    return id
+}
+
 func main() {
-    getParams()
+    rand.Seed(int64(time.Now().Nanosecond()))
+
+    err := getParams()
+    if err != nil {
+        fmt.Println(err)
+        os.Exit(1)
+    }
 
     api, err := gwacl.NewManagementAPI(subscriptionID, certFile)
     gwacl.SetVerbose(verbose)
@@ -49,8 +90,9 @@
 }
 
 func ExerciseHostedServicesAPI(api *gwacl.ManagementAPI) {
-    hostServiceName := "name-of-the-test-hosted-service"
-    fmt.Println("Creating a hosted service...")
+    // A hosted-service name must be between 3 and 24 characters long.
+    hostServiceName := makeRandomIdentifier("gwacl", 24)
+    fmt.Printf("Creating a hosted service: '%s'...\n", hostServiceName)
     createHostedService := gwacl.NewCreateHostedServiceWithLocation(hostServiceName, "testLabel", "East US")
     err := api.AddHostedService(createHostedService)
     checkError(err)
@@ -69,13 +111,18 @@
     fmt.Println("Done listing hosted services\n")
 
     fmt.Println("Adding VM deployment...")
-    configurationSet := gwacl.NewLinuxProvisioningConfiguration("testHostname12345", "test", "test123#@!", false)
+    hostname := makeRandomIdentifier("gwaclhost", 64)
+    password := makeRandomIdentifier("pwd-", 16)
+    vhdName := makeRandomIdentifier("gwacldisk", 16)
+    configurationSet := gwacl.NewLinuxProvisioningConfiguration(hostname, "test", password, false)
     // TODO: create Storage account / generate mediaLink
-    mediaLink := "http://portalvhdstjqr9wshnh85p.blob.core.windows.net/vhds/testmachinesadsadsad"
+    mediaLink := fmt.Sprintf("http://%s.blob.core.windows.net/vhds/%s.vhd", storageAccount, vhdName)
     sourceImageName := "b39f27a8b8c64d52b05eac6a62ebad85__Ubuntu-12_04_1-LTS-amd64-server-20121218-en-us-30GB"
     OSVirtualHardDisk := gwacl.NewOSVirtualHardDisk("", "", "", mediaLink, sourceImageName)
-    role := gwacl.NewRole("ExtraSmall", "test-role-123", []gwacl.LinuxProvisioningConfiguration{*configurationSet}, OSVirtualHardDisk)
-    deployment := gwacl.NewDeploymentForCreateVMDeployment("test-machine-name", "Staging", "testLabel", []gwacl.Role{*role}, "")
+    roleName := makeRandomIdentifier("gwaclrole", 16)
+    role := gwacl.NewRole("ExtraSmall", roleName, []gwacl.LinuxProvisioningConfiguration{*configurationSet}, OSVirtualHardDisk)
+    machineName := makeRandomIdentifier("gwaclmachine", 20)
+    deployment := gwacl.NewDeploymentForCreateVMDeployment(machineName, "Staging", machineName, []gwacl.Role{*role}, "")
     api.AddDeployment(deployment, hostServiceName)
     fmt.Println("Done adding VM deployment\n")