Merge lp:~jtv/gwacl/missing-error-check into lp:gwacl

Proposed by Jeroen T. Vermeulen on 2013-07-19
Status: Merged
Approved by: Jeroen T. Vermeulen on 2013-07-19
Approved revision: 194
Merged at revision: 194
Proposed branch: lp:~jtv/gwacl/missing-error-check
Merge into: lp:gwacl
Diff against target: 12 lines (+3/-0)
1 file modified
management_base.go (+3/-0)
To merge this branch: bzr merge lp:~jtv/gwacl/missing-error-check
Reviewer Review Type Date Requested Status
Gavin Panella 2013-07-19 Approve on 2013-07-19
Review via email: mp+175826@code.launchpad.net

Commit message

Missing error check in CreateAffinityGroup.

Description of the change

Another case of making error handling broken by default. Another nail in the coffin of the "Go forces you to think about error handling" myth. A traceback would have been perfectly acceptable, but continuing on with a nil pointer was not.

Jeroen

To post a comment you must log in.
Gavin Panella (allenap) wrote :

Test?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'management_base.go'
2--- management_base.go 2013-07-18 14:08:17 +0000
3+++ management_base.go 2013-07-19 13:22:29 +0000
4@@ -448,6 +448,9 @@
5 return err
6 }
7 response, err := api.session.post(url, "2012-03-01", []byte(body), "application/xml")
8+ if err != nil {
9+ return err
10+ }
11 return api.blockUntilCompleted(response)
12 }
13

Subscribers

People subscribed via source and target branches