Go Windows Azure Client Library

Merge lp:~jtv/gwacl/document-slots into lp:gwacl

  1. document-slots
  2. Merge into trunk
Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Jeroen T. Vermeulen
Approved revision: 168
Merged at revision: 168
Proposed branch: lp:~jtv/gwacl/document-slots
Merge into: lp:gwacl
Diff against target: 17 lines (+4/-3)
1 file modified
xmlobjects.go (+4/-3)
To merge this branch: bzr merge lp:~jtv/gwacl/document-slots
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+173634@code.launchpad.net

Commit message

Document the accepted values for DeploymentSlot. I'm not going as far as enforcing them; we leave that up to Azure. But this should help make it clearer what the field means. I did this after seeing "production" abbreviated to "prod" somewhere and being unsure which way to spell it for Azure.

Description of the change

And gofmt decided to re-align the struct, too.

Jeroen

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) :
review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

It got reformatted because go doc doesn't understand comments in the middle of the struct.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

go fmt, I mean.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'xmlobjects.go'
2--- xmlobjects.go 2013-07-04 16:30:34 +0000
3+++ xmlobjects.go 2013-07-09 03:20:34 +0000
4@@ -420,9 +420,10 @@
5 // Deployment is used both as input for the "Create Virtual Machine Deployment"
6 // call, and as a return value for "Get Deployment."
7 type Deployment struct {
8- XMLNS string `xml:"xmlns,attr"`
9- XMLNS_I string `xml:"xmlns:i,attr"`
10- Name string `xml:"Name"`
11+ XMLNS string `xml:"xmlns,attr"`
12+ XMLNS_I string `xml:"xmlns:i,attr"`
13+ Name string `xml:"Name"`
14+ // DeploymentSlot is either "Production" or "Staging".
15 DeploymentSlot string `xml:"DeploymentSlot"`
16 PrivateID string `xml:"PrivateID,omitempty"` // Only used for "Get Deployment."
17 Status string `xml:"Status,omitempty"` // Only used for "Get Deployment."

Subscribers

People subscribed via source and target branches