Merge lp:~jtaylor/ubuntu/raring/gnome-terminal/lp-1040885 into lp:ubuntu/raring/gnome-terminal

Proposed by Julian Taylor
Status: Approved
Approved by: Iain Lane
Approved revision: 93
Proposed branch: lp:~jtaylor/ubuntu/raring/gnome-terminal/lp-1040885
Merge into: lp:ubuntu/raring/gnome-terminal
Diff against target: 55 lines (+35/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/00_git_fix_geometry_on_focusout.patch (+26/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~jtaylor/ubuntu/raring/gnome-terminal/lp-1040885
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+188943@code.launchpad.net

Description of the change

see bug

To post a comment you must log in.

Unmerged revisions

93. By Julian Taylor

* debian/patches/00_git_fix_geometry_on_focusout.patch:
   - backport an upstream patch to not resize the geometry when having tabs
     on focus out (LP: #1040885)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-02-11 12:26:46 +0000
3+++ debian/changelog 2013-10-02 21:51:27 +0000
4@@ -1,3 +1,11 @@
5+gnome-terminal (3.6.1-0ubuntu4.1) raring-proposed; urgency=low
6+
7+ * debian/patches/00_git_fix_geometry_on_focusout.patch:
8+ - backport an upstream patch to not resize the geometry when having tabs
9+ on focus out (LP: #1040885)
10+
11+ -- Julian Taylor <jtaylor@ubuntu.com> Wed, 02 Oct 2013 19:11:49 +0200
12+
13 gnome-terminal (3.6.1-0ubuntu4) raring; urgency=low
14
15 * 02_add_transparency_properties.patch:
16
17=== added file 'debian/patches/00_git_fix_geometry_on_focusout.patch'
18--- debian/patches/00_git_fix_geometry_on_focusout.patch 1970-01-01 00:00:00 +0000
19+++ debian/patches/00_git_fix_geometry_on_focusout.patch 2013-10-02 21:51:27 +0000
20@@ -0,0 +1,26 @@
21+From 611e93f2f8c0c18ed8d365ecb850258e8d5c9c12 Mon Sep 17 00:00:00 2001
22+From: Christian Persch <chpe@gnome.org>
23+Date: Wed, 16 Jan 2013 21:52:03 +0000
24+Subject: window: Use the geometry of the active screen
25+
26+When we get the restyle on focus-out, the screens call terminal_window_set_size()
27+directly. This was causing the window to revert to a previous size, see bug
28+https://bugzilla.gnome.org/show_bug.cgi?id=688959 .
29+---
30+diff --git a/src/terminal-window.c b/src/terminal-window.c
31+index ed509ba..1740247 100644
32+--- a/src/terminal-window.c
33++++ b/src/terminal-window.c
34+@@ -2330,6 +2330,10 @@ terminal_window_set_size_force_grid (TerminalWindow *window,
35+ int grid_width;
36+ int grid_height;
37+
38++ /* Only update the geometry from the active screen. */
39++ if (window->priv->active_screen != screen)
40++ return;
41++
42+ /* be sure our geometry is up-to-date */
43+ terminal_window_update_geometry (window);
44+
45+--
46+cgit v0.9.2
47
48=== modified file 'debian/patches/series'
49--- debian/patches/series 2013-02-11 12:26:46 +0000
50+++ debian/patches/series 2013-10-02 21:51:27 +0000
51@@ -3,3 +3,4 @@
52 20_add_alt_screen_toggle_ui.patch
53 50_add_unity_quicklist.patch
54 51_fix_memleak_in_name_lost_cb.patch
55+00_git_fix_geometry_on_focusout.patch

Subscribers

People subscribed via source and target branches

to all changes: