Merge lp:~jtaylor/ubuntu/oneiric/termit/fix-803204 into lp:ubuntu/oneiric/termit

Proposed by Julian Taylor
Status: Merged
Merged at revision: 3
Proposed branch: lp:~jtaylor/ubuntu/oneiric/termit/fix-803204
Merge into: lp:ubuntu/oneiric/termit
Diff against target: 86 lines (+56/-1)
4 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/fix-as-needed-build.patch (+46/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~jtaylor/ubuntu/oneiric/termit/fix-803204
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+72344@code.launchpad.net

Description of the change

fix ftbs

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-01-11 16:39:12 +0000
3+++ debian/changelog 2011-08-21 15:10:25 +0000
4@@ -1,3 +1,10 @@
5+termit (2.6.0-1ubuntu1) oneiric; urgency=low
6+
7+ * debian/patches/fix-as-needed-build.patch:
8+ - fix build with ld --as-needed (LP: #803204)
9+
10+ -- Julian Taylor <jtaylor.debian@googlemail.com> Sun, 21 Aug 2011 17:00:06 +0200
11+
12 termit (2.6.0-1) unstable; urgency=low
13
14 * Initial release (Closes: #576409)
15
16=== modified file 'debian/control'
17--- debian/control 2011-01-11 16:39:12 +0000
18+++ debian/control 2011-08-21 15:10:25 +0000
19@@ -1,7 +1,8 @@
20 Source: termit
21 Section: misc
22 Priority: optional
23-Maintainer: Tomas Fasth <tomfa@debian.org>
24+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25+XSBC-Original-Maintainer: Tomas Fasth <tomfa@debian.org>
26 Build-Depends: cdbs, debhelper (>= 7.0.50~), cmake, libgtk2.0-dev, libvte-dev, liblua5.1-0-dev
27 Standards-Version: 3.8.4
28 Homepage: https://github.com/nonstop/termit/wiki
29
30=== added directory 'debian/patches'
31=== added file 'debian/patches/fix-as-needed-build.patch'
32--- debian/patches/fix-as-needed-build.patch 1970-01-01 00:00:00 +0000
33+++ debian/patches/fix-as-needed-build.patch 2011-08-21 15:10:25 +0000
34@@ -0,0 +1,46 @@
35+Description: fix build with ld --as-needed
36+ the CMakeLists.txt wrongly uses LINKFLAGS to register
37+ libraries to link with. This leads to a wrong ordering on the
38+ command line.
39+ ld --as-needed requires the libraries after the objects needing
40+ their symbols.
41+ Additionally FindGTK2 is used instead of FindGTK which is for gtk1
42+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/termit/+bug/803204
43+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632718
44+Author: Julian Taylor <jtaylor.debian@googlemail.com>
45+--- termit-2.6.0.orig/src/CMakeLists.txt
46++++ termit-2.6.0/src/CMakeLists.txt
47+@@ -15,7 +15,7 @@ SET(TARGET "termit")
48+
49+ INCLUDE_DIRECTORIES(${TERMIT_SOURCE_DIR})
50+
51+-INCLUDE (FindGTK)
52++INCLUDE (FindGTK2)
53+
54+ INCLUDE (FindPkgConfig)
55+ pkg_search_module(VTE REQUIRED libvte>=0.17.1 vte>=0.17.1)
56+@@ -40,8 +40,6 @@ IF(DEBUG)
57+ SET(TERMIT_CFLAGS "${TERMIT_CFLAGS} -g -D DEBUG -DGTK_DISABLE_DEPRECATED -DGSEAL_ENABLE")
58+ ENDIF(DEBUG)
59+
60+-set(TERMIT_LDFLAGS ${VTE_LDFLAGS} ${GTK_LDFLAGS})
61+-
62+ SET_SOURCE_FILES_PROPERTIES(${TERMIT_SRCS} PROPERTIES
63+ COMPILE_FLAGS "${TERMIT_CFLAGS}")
64+
65+@@ -51,13 +49,7 @@ ADD_EXECUTABLE(${TARGET} ${TERMIT_SRCS})
66+ # LINK_FLAGS ${TERMIT_LDFLAGS})
67+ #set_target_properties(${TARGET} PROPERTIES LINK_FLAGS ${TERMIT_LDFLAGS})
68+
69+-SET(TERMIT_LDFLAGS "")
70+-FOREACH(ldflag ${VTE_LDFLAGS} ${GTK_LDFLAGS})
71+- SET(TERMIT_LDFLAGS "${TERMIT_LDFLAGS} ${ldflag}")
72+-ENDFOREACH(ldflag)
73+-set_target_properties(${TARGET} PROPERTIES LINK_FLAGS "${TERMIT_LDFLAGS}")
74+-
75+-target_link_libraries(${TARGET} ${LUA_LIBRARIES})
76++target_link_libraries(${TARGET} ${LUA_LIBRARIES} ${GTK2_LIBRARIES} ${VTE_LIBRARIES})
77+
78+ INSTALL(TARGETS ${TARGET} DESTINATION ${CMAKE_INSTALL_PREFIX}/bin)
79+
80+
81
82=== added file 'debian/patches/series'
83--- debian/patches/series 1970-01-01 00:00:00 +0000
84+++ debian/patches/series 2011-08-21 15:10:25 +0000
85@@ -0,0 +1,1 @@
86+fix-as-needed-build.patch

Subscribers

People subscribed via source and target branches

to all changes: