Merge lp:~jtaylor/ubuntu/oneiric/gnubik/fix-771114 into lp:ubuntu/oneiric/gnubik

Proposed by Julian Taylor
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~jtaylor/ubuntu/oneiric/gnubik/fix-771114
Merge into: lp:ubuntu/oneiric/gnubik
Diff against target: 53 lines (+29/-1)
3 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/04-fix-as-needed-build.diff (+20/-0)
To merge this branch: bzr merge lp:~jtaylor/ubuntu/oneiric/gnubik/fix-771114
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+72334@code.launchpad.net

Description of the change

fix ftbs

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2009-09-26 16:07:56 +0000
3+++ debian/changelog 2011-08-21 14:02:23 +0000
4@@ -1,3 +1,10 @@
5+gnubik (2.3-2ubuntu1) oneiric; urgency=low
6+
7+ * debian/patches/04-fix-as-needed-build.diff:
8+ - fix build with ld --as-needed (LP: #771114)
9+
10+ -- Julian Taylor <jtaylor.debian@googlemail.com> Sun, 21 Aug 2011 15:49:59 +0200
11+
12 gnubik (2.3-2) unstable; urgency=low
13
14 * debian/copyright: Updated. Closes: #542244.
15
16=== modified file 'debian/control'
17--- debian/control 2009-09-26 16:07:56 +0000
18+++ debian/control 2011-08-21 14:02:23 +0000
19@@ -1,7 +1,8 @@
20 Source: gnubik
21 Section: games
22 Priority: optional
23-Maintainer: Bart Martens <bartm@debian.org>
24+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25+XSBC-Original-Maintainer: Bart Martens <bartm@debian.org>
26 Build-Depends: cdbs, debhelper (>= 5), autotools-dev, guile-1.8-dev, libgtkglext1-dev, autoconf (>= 2.61)
27 Standards-Version: 3.8.3
28 Homepage: http://www.gnu.org/software/gnubik/
29
30=== added file 'debian/patches/04-fix-as-needed-build.diff'
31--- debian/patches/04-fix-as-needed-build.diff 1970-01-01 00:00:00 +0000
32+++ debian/patches/04-fix-as-needed-build.diff 2011-08-21 14:02:23 +0000
33@@ -0,0 +1,20 @@
34+Description: fix build with ld --as-needed
35+ when building with ld --as-needed libraries must be placed
36+ after object files needing them on the command line so the symbols
37+ of the libraries are registered as needed.
38+ To get automake to emit the right order the libraries must be placed in
39+ LDADD and not LDFLAGS.
40+Author: Julian Taylor <jtaylor.debian@googlemail.com>
41+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/gnubik/+bug/771114
42+diff -Nur -x '*.orig' -x '*~' gnubik-2.3//Makefile.in gnubik-2.3.new//Makefile.in
43+--- gnubik-2.3//Makefile.in 2009-01-06 04:02:34.000000000 +0100
44++++ gnubik-2.3.new//Makefile.in 2011-07-08 11:52:12.745774746 +0200
45+@@ -278,7 +278,7 @@
46+ AM_CFLAGS = $(am__append_1)
47+ src_gnubik_CPPFLAGS = $(AM_CPPFLAGS)
48+ src_gnubik_CFLAGS = $(AM_CFLAGS) $(GTK_CFLAGS) $(GDK_GL_EXT_CFLAGS) $(GTK_GL_EXT_CFLAGS)
49+-src_gnubik_LDFLAGS = $(GTK_LIBS) $(GDK_GL_EXT_LIBS) $(GTK_GL_EXT_LIBS)
50++src_gnubik_LDADD = $(GTK_LIBS) $(GDK_GL_EXT_LIBS) $(GTK_GL_EXT_LIBS)
51+ src_gnubik_SOURCES = \
52+ src/colour-sel.c \
53+ src/colour-sel.h \

Subscribers

People subscribed via source and target branches

to all changes: