Merge lp:~jtatum/ubuntuone-client/bug-465030 into lp:ubuntuone-client
Proposed by
James Tatum
on 2009-11-06
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Joshua Blount on 2009-11-06 | ||||
Approved revision: | 275 | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~jtatum/ubuntuone-client/bug-465030 | ||||
Merge into: | lp:ubuntuone-client | ||||
Diff against target: |
17 lines (+3/-0) 1 file modified
bin/ubuntuone-client-preferences (+3/-0) |
||||
To merge this branch: | bzr merge lp:~jtatum/ubuntuone-client/bug-465030 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Joshua Blount (community) | Approve on 2009-11-06 | ||
Vincenzo Di Somma (community) | Approve on 2009-11-06 | ||
Rick McBride (community) | 2009-11-06 | Approve on 2009-11-06 | |
Review via email:
|
Commit message
Update bandwidth controls on init with values from dbus
To post a comment you must log in.
James Tatum (jtatum) wrote : | # |
Rick McBride (rmcbride) wrote : | # |
This looks great! behaves as described. There's some discussion on the behavior of value '0', but that doesn't have any real bearing on this fix. If that value needs to be "handled" it is a seperate issue from the save/retrieve problem.
review:
Approve
review:
Approve
The bandwidth settings in the preferences window do not appear to be saved. On closer examination, they were being retrieved correctly but only the internal state was being updated with the values. The controls were not being set. Added a bit of code to set the controls accordingly.