Code review comment for lp:~jtatum/mago/pidgin-exception

Revision history for this message
James Tatum (jtatum) wrote :

Hi Javier,

I agree in principle. Many mago tests already require some configuration of some kind or another and so users should be examining the various README files to see what the prerequisites are. I think the case here is for users that want to use the mago framework but who aren't running all the test suites that are shipping with it. Should the mago package pull in a bunch of libraries that only get used for specific tests? This is a philosophical question.

If the answer is yes, we should probably add the debian directory in to the bzr tree so dependencies can get added as they are added to the source. Mago is not just an ubuntu project, so they need to be documented elsewhere as well.

For what it's worth, without this patch, mago actually crashes when running the suite and does not output a log for the pidgin tests or continue to more tests if you do not have one of the libraries.

« Back to merge proposal