Merge lp:~jstpierre/loggerhead/fix-569358 into lp:loggerhead
Proposed by
Jasper St. Pierre
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | John A Meinel | ||||
Approved revision: | 435 | ||||
Merged at revision: | 434 | ||||
Proposed branch: | lp:~jstpierre/loggerhead/fix-569358 | ||||
Merge into: | lp:loggerhead | ||||
Diff against target: |
123 lines (+39/-6) 4 files modified
loggerhead/controllers/inventory_ui.py (+6/-3) loggerhead/controllers/view_ui.py (+4/-1) loggerhead/tests/test_controllers.py (+1/-1) loggerhead/tests/test_simple.py (+28/-1) |
||||
To merge this branch: | bzr merge lp:~jstpierre/loggerhead/fix-569358 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John A Meinel | Approve | ||
Review via email: mp+53137@code.launchpad.net |
Description of the change
Fix bug 569358 - "Cannot view directory by editing URLs"
Helping lvh out one by one.
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 3/12/2011 6:29 PM, Jasper St. Pierre wrote: reviewers) /bugs.launchpad .net/loggerhead /+bug/569358 /code.launchpad .net/~jstpierre /loggerhead/ fix-569358/ +merge/ 53137
> Jasper St. Pierre has proposed merging lp:~jstpierre/loggerhead/fix-569358 into lp:loggerhead.
>
> Requested reviews:
> Loggerhead Reviewers (loggerhead-
> Related bugs:
> Bug #569358 in loggerhead: "Cannot view a directory by editing urls"
> https:/
>
> For more details, see:
> https:/
>
> Fix bug 569358 - "Cannot view directory by editing URLs"
>
> Helping lvh out one by one.
Would it be possible to add some tests here? If you need help, you can
ask. A simple test that builds a tree with both a file and a directory,
and ensures that asking for /view of the directory triggers a redirect
exception, and /files of the file triggers the appropriate redirect?
review: needsfixing
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
9+dAACgkQJdeBCY SNAANjYQCgr1+ wNnKKpV7bYrr7eq tvDOqW vwGwHihMJJlrijs m1
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk1
cgMAoJSurns7LZC
=iq2S
-----END PGP SIGNATURE-----