Merge lp:~jspreddy/xibo/xibo-jumplist-styling into lp:xibo/1.5

Proposed by Sai Phaninder Reddy
Status: Merged
Approved by: Dan Garner
Approved revision: 287
Merged at revision: 287
Proposed branch: lp:~jspreddy/xibo/xibo-jumplist-styling
Merge into: lp:xibo/1.5
Diff against target: 48 lines (+19/-11)
1 file modified
server/theme/default/css/xibo.css (+19/-11)
To merge this branch: bzr merge lp:~jspreddy/xibo/xibo-jumplist-styling
Reviewer Review Type Date Requested Status
Dan Garner code ui Approve
Review via email: mp+179252@code.launchpad.net

Description of the change

Style changes on the Layout Jumplist.
This is visible on the bottom right of the design layout page.

To post a comment you must log in.
Revision history for this message
Dan Garner (dangarner) wrote :

Looks much better, will merge in for 1.5.2

review: Approve (code ui)
Revision history for this message
Dan Garner (dangarner) wrote :

Thank you very much for this code patch!

Revision history for this message
Sai Phaninder Reddy (jspreddy) wrote :

I would need your project settings. Like tab length, code formatting rules, etc...
so that my code will follow your code formatting.

I use netbeans for development.

I am planning to actively contribute to the project.

Revision history for this message
Dan Garner (dangarner) wrote :

Sounds great - drop us an email at <email address hidden> and we will outline how we do things.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'server/theme/default/css/xibo.css'
2--- server/theme/default/css/xibo.css 2013-05-25 12:26:15 +0000
3+++ server/theme/default/css/xibo.css 2013-08-08 18:40:54 +0000
4@@ -90,26 +90,34 @@
5
6 /* Layout Jump List */
7 #LayoutJumpList {
8- position: absolute;
9- width: 450px;
10- right: 25px;
11- bottom: 55px;
12-}
13-
14-#LayoutJumpList .XiboGrid {
15- height: 530px;
16+ z-index: 1;
17+ position: absolute;
18+ min-width: 150px;
19+ right: 5px;
20+ bottom: 5px;
21+ border:1px solid #e0e0e0;
22+ background-color:#f9f9f9;
23+}
24+
25+#LayoutJumpList:hover{
26+ border-color:#a0a0a0;
27+}
28+
29+#LayoutJumpList .XiboGrid {
30 overflow-y: auto;
31 overflow-x: hidden;
32 margin: 0;
33- padding: 0;
34+ padding: 8px;
35 }
36
37 #JumpListHeader {
38- text-align: right;
39+ text-align: left;
40+ border-bottom:1px solid #a0a0a0;
41+ padding:3px 8px;
42 }
43
44 #JumpListOpenClose {
45- margin-left: 50px;
46+ float:right;
47 font-weight: bold;
48 }
49

Subscribers

People subscribed via source and target branches