Merge ~jslarraz/ubuntu-qa-tools:add-premissions-for-libvirt-qemu-user into ubuntu-qa-tools:master

[Jorge Sancho Larraz]

uvt: grant libvirt-qemu search permissions on required directories

libvirt-qemu user requires search permissions all the way up vm_path and vm_dir_iso_cache. This uses setfacl to ensure that this requirement is met.

I'm just wondering if we also want to pronpt the user for this one

[Marc Deslauriers (mdeslaur)]

Yeah, I think prompting the user is best here too, especially since these directories could be anywhere depending on what the user selected, and the use of extended acls isn't immediately obvious.

[Jorge Sancho Larraz (jslarraz)]

Updated to ask user before granting required permissions in commit https://git.launchpad.net/~jslarraz/ubuntu-qa-tools/commit/?id=8cb5322e58ab28d45452153052dbe81fe54a3851

[Marc Deslauriers (mdeslaur)]

LGTM, thanks!

review: Approve

diff --git a/vm-tools/uvt b/vm-tools/uvt
index 0095643..69538d4 100755
--- a/vm-tools/uvt
+++ b/vm-tools/uvt
@@ -3554,6 +3554,32 @@ def load_uvt_config():
             print("Creating '%s' directory..." % config[d])
             os.makedirs(config[d])
 
+        # Ensure libvirt-qemu user has search permissions all the way up the path
+        # https://github.com/jedi4ever/veewee/issues/996
+        path = config[d]
+        while path != "/":
+            rc, out = runcmd(["getfacl", "-e", path])
+            if (not os.stat(path).st_mode & 0o001) and (re.search("user:libvirt-qemu:..x", out) is None):
+
+                print("Missing permissions found while creating '%s' directory. libvirt-qemu user "
+                      "requires search permission all the way up the path, but it seems to be"
+                      "missing on directory '%s'" % (d, path))
+                print("If you wish to change the location where '%s' is "
+                      "stored, you can launch 'uvt config', which will create "
+                      "a default config file in ~/%s that you can customize. " % (d, config_file))
+                print("")
+                if not confirm("Would you like to grant libvirt-qemu search permissions on '%s'?" % path):
+                    print("Aborting.")
+                    sys.exit(1)
+
+                rc, out = runcmd(["setfacl", "-m", "u:libvirt-qemu:rx", path])
+                if rc != 0:
+                    print("Error while granting libvirt-qemu search permissions on "
+                          "directory: '%s'. You can do it manully by issuing: " % path)
+                    print("setfacl -m u:libvirt-qemu:rx " + path)
+
+            path = os.path.abspath(os.path.join(path, os.pardir))
+
     conf_hash = hashlib.sha256((repr(sorted(config.items())).encode())).hexdigest()
 
     return (config, conf_hash)