Merge ~jslarraz/ubuntu-qa-tools:add-vm-name-resolution into ubuntu-qa-tools:master
Status: | Rejected |
---|---|
Rejected by: | Jorge Sancho Larraz |
Proposed branch: | ~jslarraz/ubuntu-qa-tools:add-vm-name-resolution |
Merge into: | ubuntu-qa-tools:master |
Diff against target: |
124 lines (+69/-9) 1 file modified
vm-tools/uvt (+69/-9) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Bug Control | Pending | ||
Review via email: mp+460382@code.launchpad.net |
Commit message
uvt: add cmd_ssh and perform address resolution using virsh when possible
Description of the change
When trying to create a snap with uvt I was not able to make address resolution using libnss-libvirt to work.
This MR modifies uvt to perform the address resolution internally using `virsh domifaddr` instead of relying on the OS. It will fallback to the old behavior if this resolution does not work.
This MR also add a new command called `uvt ssh <vm-name> (pretty much a shortcut for `uvt cmd <vm-name> bash`) that opens an interactive session in the target machine.
Both changes together may remove the need of network setup (install libnss-libvirt + config /etc/nsswitch.conf) from the setup step on certain configurations. It will additionally enable us to package uvt as a snap
I just ripped out domifaddr support because we wanted to standardize on the same configuration for everyone and domifaddr support was limited and wouldn't allow resolving from the host.
https:/ /git.launchpad. net/ubuntu- qa-tools/ commit/ vm-tools/ uvt?id= 43be4941455b466 d7be5e263ee6f34 5be7377277
Perhaps you can add your patch to your snap instead of the main repo?