Merge ~jslarraz/review-tools:add-dm-multipaht-iscsi-initiator-nvme-control-interfaces into review-tools:master

[Jorge Sancho Larraz]

[Paulo Flabiano Smorigo (pfsmorigo)]

LGTM

review: Approve

diff --git a/reviewtools/data/snapd-base-declaration.yaml b/reviewtools/data/snapd-base-declaration.yaml
index ab29f87..94df4b3 100644
--- a/reviewtools/data/snapd-base-declaration.yaml
+++ b/reviewtools/data/snapd-base-declaration.yaml
@@ -46,6 +46,9 @@
   dm-crypt:
     allow-installation: false
     deny-auto-connection: true
+  dm-multipath:
+    allow-installation: false
+    deny-auto-connection: true
   docker-support:
     allow-installation: false
     deny-auto-connection: true
@@ -75,6 +78,9 @@
   ion-memory-control:
     allow-installation: false
     deny-auto-connection: true
+  iscsi-initiator:
+    allow-installation: false
+    deny-auto-connection: true
   kernel-firmware-control:
     allow-installation: false
     deny-auto-connection: true
@@ -108,6 +114,9 @@
   nvidia-drivers-support:
     allow-installation: false
     deny-auto-connection: true
+  nvme-control:
+    allow-installation: false
+    deny-auto-connection: true
   opengl-driver-libs:
     allow-installation:
       plug-snap-type:
@@ -482,6 +491,11 @@
       slot-snap-type:
         - core
     deny-auto-connection: true
+  dm-multipath:
+    allow-installation:
+      slot-snap-type:
+        - core
+    deny-auto-connection: true
   docker:
     allow-installation: false
     deny-connection: true
@@ -662,6 +676,11 @@
       slot-snap-type:
         - core
     deny-auto-connection: true
+  iscsi-initiator:
+    allow-installation:
+      slot-snap-type:
+        - core
+    deny-auto-connection: true
   jack1:
     allow-installation:
       slot-snap-type:
@@ -914,6 +933,11 @@
       slot-snap-type:
         - core
     deny-auto-connection: true
+  nvme-control:
+    allow-installation:
+      slot-snap-type:
+        - core
+    deny-auto-connection: true
   ofono:
     allow-installation:
       slot-snap-type:
diff --git a/reviewtools/schemas/definitions.json b/reviewtools/schemas/definitions.json
index e226003..55c50a2 100644
--- a/reviewtools/schemas/definitions.json
+++ b/reviewtools/schemas/definitions.json
@@ -48,6 +48,7 @@
         "device-buttons",
         "display-control",
         "dm-crypt",
+        "dm-multipath",
         "docker",
         "docker-support",
         "dsp",
@@ -82,6 +83,7 @@
         "intel-qat",
         "io-ports-control",
         "ion-memory-control",
+        "iscsi-initiator",
         "jack1",
         "joystick",
         "juju-client-observe",
@@ -130,6 +132,7 @@
         "nfs-mount",
         "nomad-support",
         "nvidia-drivers-support",
+        "nvme-control",
         "ofono",
         "online-accounts-service",
         "opengl",
diff --git a/reviewtools/schemas/plugs.json b/reviewtools/schemas/plugs.json
index b9a86a3..0c790ba 100644
--- a/reviewtools/schemas/plugs.json
+++ b/reviewtools/schemas/plugs.json
@@ -1562,7 +1562,7 @@
         }
       ]
     },
-    "^(?!(accel|account-control|accounts-service|acrn-support|adb-support|allegro-vcu|alsa|appstream-metadata|audio-playback|audio-record|auditd-support|autopilot-introspection|avahi-control|avahi-observe|block-devices|bluetooth-control|bluez|bool-file|broadcom-asic-control|browser-support|calendar-service|camera|can-bus|checkbox-support|cifs-mount|classic-support|confdb|contacts-service|content|core-support|cpu-control|cuda-driver-libs|cups|cups-control|custom-device|daemon-notify|dbus|dcdbas-control|desktop|desktop-launch|desktop-legacy|device-buttons|display-control|dm-crypt|docker|docker-support|dsp|dvb|egl-driver-libs|firewall-control|firmware-updater-support|fpga|framebuffer|fuse-support|fwupd|gbm-driver-libs|gconf|gpg-keys|gpg-public-keys|gpio|gpio-chardev|gpio-control|gpio-memory-control|greengrass-support|gsettings|hardware-observe|hardware-random-control|hardware-random-observe|hidraw|home|hostname-control|hugepages-control|i2c|iio|intel-mei|intel-qat|io-ports-control|ion-memory-control|jack1|joystick|juju-client-observe|kerberos-tickets|kernel-crypto-api|kernel-firmware-control|kernel-module-control|kernel-module-load|kernel-module-observe|kubernetes-support|kvm|libvirt|locale-control|location-control|location-observe|log-observe|login-session-control|login-session-observe|lxd|lxd-support|maliit|media-control|media-hub|microceph|microceph-support|microovn|microstack-support|mir|modem-manager|mount-control|mount-observe|mpris|multipass-support|netlink-audit|netlink-connector|netlink-driver|network|network-bind|network-control|network-manager|network-manager-observe|network-observe|network-setup-control|network-setup-observe|network-status|nfs-mount|nomad-support|nvidia-drivers-support|ofono|online-accounts-service|opengl|opengl-driver-libs|opengles-driver-libs|openvswitch|openvswitch-support|optical-drive|packagekit-control|password-manager-service|pcscd|personal-files|physical-memory-control|physical-memory-observe|pipewire|pkcs11|polkit|polkit-agent|posix-mq|power-control|ppp|process-control|ptp|pulseaudio|pwm|qualcomm-ipc-router|raw-input|raw-usb|raw-volume|remoteproc|removable-media|ros-opt-data|ros-snapd-support|screen-inhibit-control|screencast-legacy|scsi-generic|sd-control|serial-port|shared-memory|shutdown|snap-fde-control|snap-interfaces-requests-control|snap-refresh-control|snap-refresh-observe|snap-themes-control|snapd-control|spi|ssh-keys|ssh-public-keys|steam-support|storage-framework-service|system-backup|system-files|system-observe|system-packages-doc|system-source-code|system-trace|tee|thumbnailer-service|time-control|timeserver-control|timezone-control|tpm|u2f-devices|ubuntu-download-manager|udisks2|uhid|uinput|uio|unity7|unity8|unity8-calendar|unity8-contacts|upower-observe|usb-gadget|userns|vcio|vulkan-driver-libs|wayland|x11|xilinx-dma)).+$": {
+    "^(?!(accel|account-control|accounts-service|acrn-support|adb-support|allegro-vcu|alsa|appstream-metadata|audio-playback|audio-record|auditd-support|autopilot-introspection|avahi-control|avahi-observe|block-devices|bluetooth-control|bluez|bool-file|broadcom-asic-control|browser-support|calendar-service|camera|can-bus|checkbox-support|cifs-mount|classic-support|confdb|contacts-service|content|core-support|cpu-control|cuda-driver-libs|cups|cups-control|custom-device|daemon-notify|dbus|dcdbas-control|desktop|desktop-launch|desktop-legacy|device-buttons|display-control|dm-crypt|dm-multipath|docker|docker-support|dsp|dvb|egl-driver-libs|firewall-control|firmware-updater-support|fpga|framebuffer|fuse-support|fwupd|gbm-driver-libs|gconf|gpg-keys|gpg-public-keys|gpio|gpio-chardev|gpio-control|gpio-memory-control|greengrass-support|gsettings|hardware-observe|hardware-random-control|hardware-random-observe|hidraw|home|hostname-control|hugepages-control|i2c|iio|intel-mei|intel-qat|io-ports-control|ion-memory-control|iscsi-initiator|jack1|joystick|juju-client-observe|kerberos-tickets|kernel-crypto-api|kernel-firmware-control|kernel-module-control|kernel-module-load|kernel-module-observe|kubernetes-support|kvm|libvirt|locale-control|location-control|location-observe|log-observe|login-session-control|login-session-observe|lxd|lxd-support|maliit|media-control|media-hub|microceph|microceph-support|microovn|microstack-support|mir|modem-manager|mount-control|mount-observe|mpris|multipass-support|netlink-audit|netlink-connector|netlink-driver|network|network-bind|network-control|network-manager|network-manager-observe|network-observe|network-setup-control|network-setup-observe|network-status|nfs-mount|nomad-support|nvidia-drivers-support|nvme-control|ofono|online-accounts-service|opengl|opengl-driver-libs|opengles-driver-libs|openvswitch|openvswitch-support|optical-drive|packagekit-control|password-manager-service|pcscd|personal-files|physical-memory-control|physical-memory-observe|pipewire|pkcs11|polkit|polkit-agent|posix-mq|power-control|ppp|process-control|ptp|pulseaudio|pwm|qualcomm-ipc-router|raw-input|raw-usb|raw-volume|remoteproc|removable-media|ros-opt-data|ros-snapd-support|screen-inhibit-control|screencast-legacy|scsi-generic|sd-control|serial-port|shared-memory|shutdown|snap-fde-control|snap-interfaces-requests-control|snap-refresh-control|snap-refresh-observe|snap-themes-control|snapd-control|spi|ssh-keys|ssh-public-keys|steam-support|storage-framework-service|system-backup|system-files|system-observe|system-packages-doc|system-source-code|system-trace|tee|thumbnailer-service|time-control|timeserver-control|timezone-control|tpm|u2f-devices|ubuntu-download-manager|udisks2|uhid|uinput|uio|unity7|unity8|unity8-calendar|unity8-contacts|upower-observe|usb-gadget|userns|vcio|vulkan-driver-libs|wayland|x11|xilinx-dma)).+$": {
       "oneOf": [
         {
           "type": "string",
diff --git a/reviewtools/schemas/slots.json b/reviewtools/schemas/slots.json
index 12d0d65..0971a64 100644
--- a/reviewtools/schemas/slots.json
+++ b/reviewtools/schemas/slots.json
@@ -1904,7 +1904,7 @@
         }
       ]
     },
-    "^(?!(accel|account-control|accounts-service|acrn-support|adb-support|allegro-vcu|alsa|appstream-metadata|audio-playback|audio-record|auditd-support|autopilot-introspection|avahi-control|avahi-observe|block-devices|bluetooth-control|bluez|bool-file|broadcom-asic-control|browser-support|calendar-service|camera|can-bus|checkbox-support|cifs-mount|classic-support|confdb|contacts-service|content|core-support|cpu-control|cuda-driver-libs|cups|cups-control|custom-device|daemon-notify|dbus|dcdbas-control|desktop|desktop-launch|desktop-legacy|device-buttons|display-control|dm-crypt|docker|docker-support|dsp|dvb|egl-driver-libs|firewall-control|firmware-updater-support|fpga|framebuffer|fuse-support|fwupd|gbm-driver-libs|gconf|gpg-keys|gpg-public-keys|gpio|gpio-chardev|gpio-control|gpio-memory-control|greengrass-support|gsettings|hardware-observe|hardware-random-control|hardware-random-observe|hidraw|home|hostname-control|hugepages-control|i2c|iio|intel-mei|intel-qat|io-ports-control|ion-memory-control|jack1|joystick|juju-client-observe|kerberos-tickets|kernel-crypto-api|kernel-firmware-control|kernel-module-control|kernel-module-load|kernel-module-observe|kubernetes-support|kvm|libvirt|locale-control|location-control|location-observe|log-observe|login-session-control|login-session-observe|lxd|lxd-support|maliit|media-control|media-hub|microceph|microceph-support|microovn|microstack-support|mir|modem-manager|mount-control|mount-observe|mpris|multipass-support|netlink-audit|netlink-connector|netlink-driver|network|network-bind|network-control|network-manager|network-manager-observe|network-observe|network-setup-control|network-setup-observe|network-status|nfs-mount|nomad-support|nvidia-drivers-support|ofono|online-accounts-service|opengl|opengl-driver-libs|opengles-driver-libs|openvswitch|openvswitch-support|optical-drive|packagekit-control|password-manager-service|pcscd|personal-files|physical-memory-control|physical-memory-observe|pipewire|pkcs11|polkit|polkit-agent|posix-mq|power-control|ppp|process-control|ptp|pulseaudio|pwm|qualcomm-ipc-router|raw-input|raw-usb|raw-volume|remoteproc|removable-media|ros-opt-data|ros-snapd-support|screen-inhibit-control|screencast-legacy|scsi-generic|sd-control|serial-port|shared-memory|shutdown|snap-fde-control|snap-interfaces-requests-control|snap-refresh-control|snap-refresh-observe|snap-themes-control|snapd-control|spi|ssh-keys|ssh-public-keys|steam-support|storage-framework-service|system-backup|system-files|system-observe|system-packages-doc|system-source-code|system-trace|tee|thumbnailer-service|time-control|timeserver-control|timezone-control|tpm|u2f-devices|ubuntu-download-manager|udisks2|uhid|uinput|uio|unity7|unity8|unity8-calendar|unity8-contacts|upower-observe|usb-gadget|userns|vcio|vulkan-driver-libs|wayland|x11|xilinx-dma)).+$": {
+    "^(?!(accel|account-control|accounts-service|acrn-support|adb-support|allegro-vcu|alsa|appstream-metadata|audio-playback|audio-record|auditd-support|autopilot-introspection|avahi-control|avahi-observe|block-devices|bluetooth-control|bluez|bool-file|broadcom-asic-control|browser-support|calendar-service|camera|can-bus|checkbox-support|cifs-mount|classic-support|confdb|contacts-service|content|core-support|cpu-control|cuda-driver-libs|cups|cups-control|custom-device|daemon-notify|dbus|dcdbas-control|desktop|desktop-launch|desktop-legacy|device-buttons|display-control|dm-crypt|dm-multipath|docker|docker-support|dsp|dvb|egl-driver-libs|firewall-control|firmware-updater-support|fpga|framebuffer|fuse-support|fwupd|gbm-driver-libs|gconf|gpg-keys|gpg-public-keys|gpio|gpio-chardev|gpio-control|gpio-memory-control|greengrass-support|gsettings|hardware-observe|hardware-random-control|hardware-random-observe|hidraw|home|hostname-control|hugepages-control|i2c|iio|intel-mei|intel-qat|io-ports-control|ion-memory-control|iscsi-initiator|jack1|joystick|juju-client-observe|kerberos-tickets|kernel-crypto-api|kernel-firmware-control|kernel-module-control|kernel-module-load|kernel-module-observe|kubernetes-support|kvm|libvirt|locale-control|location-control|location-observe|log-observe|login-session-control|login-session-observe|lxd|lxd-support|maliit|media-control|media-hub|microceph|microceph-support|microovn|microstack-support|mir|modem-manager|mount-control|mount-observe|mpris|multipass-support|netlink-audit|netlink-connector|netlink-driver|network|network-bind|network-control|network-manager|network-manager-observe|network-observe|network-setup-control|network-setup-observe|network-status|nfs-mount|nomad-support|nvidia-drivers-support|nvme-control|ofono|online-accounts-service|opengl|opengl-driver-libs|opengles-driver-libs|openvswitch|openvswitch-support|optical-drive|packagekit-control|password-manager-service|pcscd|personal-files|physical-memory-control|physical-memory-observe|pipewire|pkcs11|polkit|polkit-agent|posix-mq|power-control|ppp|process-control|ptp|pulseaudio|pwm|qualcomm-ipc-router|raw-input|raw-usb|raw-volume|remoteproc|removable-media|ros-opt-data|ros-snapd-support|screen-inhibit-control|screencast-legacy|scsi-generic|sd-control|serial-port|shared-memory|shutdown|snap-fde-control|snap-interfaces-requests-control|snap-refresh-control|snap-refresh-observe|snap-themes-control|snapd-control|spi|ssh-keys|ssh-public-keys|steam-support|storage-framework-service|system-backup|system-files|system-observe|system-packages-doc|system-source-code|system-trace|tee|thumbnailer-service|time-control|timeserver-control|timezone-control|tpm|u2f-devices|ubuntu-download-manager|udisks2|uhid|uinput|uio|unity7|unity8|unity8-calendar|unity8-contacts|upower-observe|usb-gadget|userns|vcio|vulkan-driver-libs|wayland|x11|xilinx-dma)).+$": {
       "oneOf": [
         {
           "type": "string",