Merge lp:~jsjgruber/ubuntu/oneiric/lernid/lernid.fix799211 into lp:ubuntu/oneiric/lernid

Proposed by John S. Gruber
Status: Merged
Merged at revision: 5
Proposed branch: lp:~jsjgruber/ubuntu/oneiric/lernid/lernid.fix799211
Merge into: lp:ubuntu/oneiric/lernid
Diff against target: 173 lines (+27/-15)
10 files modified
debian/changelog (+7/-0)
debian/control (+0/-1)
debian/rules (+0/-1)
lernid/AboutLernidDialog.py (+1/-1)
lernid/lernidconfig.py (+3/-1)
lernid/widgets/Classroom.py (+0/-1)
lernid/widgets/IrcWidget.py (+11/-4)
lernid/widgets/NativeChatroom.py (+0/-1)
lernid/widgets/WebChatroom.py (+4/-4)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~jsjgruber/ubuntu/oneiric/lernid/lernid.fix799211
Reviewer Review Type Date Requested Status
Stefano Rivera Approve
Ubuntu branches Pending
Review via email: mp+65649@code.launchpad.net

Description of the change

Thanks to Chris Coulson for these changes.

To post a comment you must log in.
Revision history for this message
Stefano Rivera (stefanor) wrote :

I'll add a dependency on python-webkit, merge with https://code.launchpad.net/~wibblymat/ubuntu/oneiric/lernid/remove-pycentral/+merge/65677
and upload

review: Approve
Revision history for this message
Stefano Rivera (stefanor) wrote :

There was an unexpected tab on line 143 of this diff

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-04-19 04:02:07 +0000
3+++ debian/changelog 2011-06-23 12:26:08 +0000
4@@ -1,3 +1,10 @@
5+lernid (0.8.0.2~jsgppatwo3) oneiric; urgency=low
6+
7+ * Closes: LP: #799211 Remove dependency on python-gtkmozembed to support
8+ Oneiric changes; address reported FTBFS under Oneiric
9+
10+ -- John S Gruber <JohnSGruber@gmail.com> Sat, 18 Jun 2011 14:25:59 -0400
11+
12 lernid (0.8.0.1) natty; urgency=low
13
14 * Closes: LP: #749848: Revert the slide loading function to run synchronously
15
16=== modified file 'debian/control'
17--- debian/control 2011-03-31 01:06:03 +0000
18+++ debian/control 2011-06-23 12:26:08 +0000
19@@ -16,7 +16,6 @@
20 Depends: ${misc:Depends},
21 ${python:Depends},
22 python-xdg,
23- python-gtkmozembed,
24 python-telepathy,
25 python-dbus,
26 python-desktopcouch-records,
27
28=== modified file 'debian/rules'
29--- debian/rules 2010-02-24 22:58:17 +0000
30+++ debian/rules 2011-06-23 12:26:08 +0000
31@@ -4,7 +4,6 @@
32
33 include /usr/share/cdbs/1/rules/debhelper.mk
34 include /usr/share/cdbs/1/class/python-distutils.mk
35-include /usr/share/cdbs/1/rules/langpack.mk
36
37 binary-fixup/lernid::
38 find debian/lernid/usr/share/ -type d -empty -delete
39
40=== modified file 'lernid/AboutLernidDialog.py'
41--- lernid/AboutLernidDialog.py 2010-02-24 22:58:17 +0000
42+++ lernid/AboutLernidDialog.py 2011-06-23 12:26:08 +0000
43@@ -47,7 +47,7 @@
44 self.builder = builder
45 self.builder.connect_signals(self)
46
47- self.set_comments(DESCRIPTION)
48+ self.set_comments(_(DESCRIPTION))
49 self.set_version(VERSION)
50 self.set_website(WEBSITE)
51 self.set_authors(CONTRIBUTORS)
52
53=== modified file 'lernid/lernidconfig.py'
54--- lernid/lernidconfig.py 2010-07-31 08:42:13 +0000
55+++ lernid/lernidconfig.py 2011-06-23 12:26:08 +0000
56@@ -29,7 +29,9 @@
57 import os
58 import xdg.BaseDirectory
59
60-VERSION = '0.6'
61+def _(message): return message
62+
63+VERSION = '0.8.0.2'
64 DESCRIPTION = _('Connect to a world of online tutorials quickly and easily.')
65 WEBSITE = 'http://wiki.ubuntu.com/Lernid'
66 CONTRIBUTORS = [
67
68=== modified file 'lernid/widgets/Classroom.py'
69--- lernid/widgets/Classroom.py 2011-03-31 01:06:03 +0000
70+++ lernid/widgets/Classroom.py 2011-06-23 12:26:08 +0000
71@@ -19,7 +19,6 @@
72
73 import gtk
74 import gobject
75-import gtkmozembed
76 import pango
77 import time
78
79
80=== modified file 'lernid/widgets/IrcWidget.py'
81--- lernid/widgets/IrcWidget.py 2010-07-31 08:42:13 +0000
82+++ lernid/widgets/IrcWidget.py 2011-06-23 12:26:08 +0000
83@@ -30,8 +30,15 @@
84
85 class IrcWidget(Widget):
86
87- hand_cursor = gtk.gdk.Cursor(gtk.gdk.HAND2)
88- regular_cursor = gtk.gdk.Cursor(gtk.gdk.XTERM)
89+ def get_hand_cursor(self):
90+ if not hasattr(self, "_hand_cursor"):
91+ self._hand_cursor = gtk.gdk.Cursor(gtk.gdk.HAND2)
92+ return self._hand_cursor
93+
94+ def get_regular_cursor(self):
95+ if not hasattr(self, "_regular_cursor"):
96+ self._regular_cursor = gtk.gdk.Cursor(gtk.gdk.XTERM)
97+ return self._regular_cursor
98
99 def do_event_connect(self, event_man, event):
100 self._browser = event_man.get_widget_by_name('browser')
101@@ -92,9 +99,9 @@
102 int(event.x), int(event.y))
103 iter = text_view.get_iter_at_location(x, y)
104 if (iter.has_tag(tag)):
105- text_view.get_window(gtk.TEXT_WINDOW_TEXT).set_cursor(self.hand_cursor)
106+ text_view.get_window(gtk.TEXT_WINDOW_TEXT).set_cursor(self.get_hand_cursor())
107 else:
108- text_view.get_window(gtk.TEXT_WINDOW_TEXT).set_cursor(self.regular_cursor)
109+ text_view.get_window(gtk.TEXT_WINDOW_TEXT).set_cursor(self.get_regular_cursor())
110 return False
111
112 def _focus_out(self, widget, event):
113
114=== modified file 'lernid/widgets/NativeChatroom.py'
115--- lernid/widgets/NativeChatroom.py 2011-03-31 01:06:03 +0000
116+++ lernid/widgets/NativeChatroom.py 2011-06-23 12:26:08 +0000
117@@ -20,7 +20,6 @@
118
119 import gtk
120 import gobject
121-import gtkmozembed
122 import urlparse
123 import logging
124 import pango
125
126=== modified file 'lernid/widgets/WebChatroom.py'
127--- lernid/widgets/WebChatroom.py 2010-02-24 22:58:17 +0000
128+++ lernid/widgets/WebChatroom.py 2011-06-23 12:26:08 +0000
129@@ -19,7 +19,7 @@
130
131 import gtk
132 import gobject
133-import gtkmozembed
134+import webkit
135
136 from lernid.widgets.Widget import Widget
137
138@@ -37,7 +37,7 @@
139 Widget.__init__(self, 'chatroom')
140 scroll = gtk.ScrolledWindow()
141 scroll.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC)
142- self._chat = gtkmozembed.MozEmbed()
143+ self._chat = webkit.WebView()
144 scroll.add_with_viewport(self._chat)
145 self.add(scroll)
146
147@@ -50,11 +50,11 @@
148 def do_event_connect(self, event_man, event):
149 chatirc = 'http://webchat.freenode.net/?nick={nick}&channels={chans}'.format(
150 nick=event.nick, chans=event.chat)
151- self._chat.load_url(chatirc)
152+ self._chat.load_uri(chatirc)
153 self._chat.show()
154
155 def do_event_disconnect(self, event_man, event):
156- self._chat.load_url('about:blank')
157+ self._chat.load_uri('about:blank')
158 self._chat.hide()
159
160 def get_input_widget(self):
161
162=== modified file 'setup.py'
163--- setup.py 2010-02-24 22:58:17 +0000
164+++ setup.py 2011-06-23 12:26:08 +0000
165@@ -75,7 +75,7 @@
166
167 DistUtilsExtra.auto.setup(
168 name='lernid',
169- version='0.7',
170+ version='0.8.0.2',
171 license='GPL-3',
172 author='Michael Budde',
173 author_email='mbudde@gmail.com',

Subscribers

People subscribed via source and target branches