Merge ~jsimpso/prometheus-pushgateway-snap:master into prometheus-pushgateway-snap:master

Proposed by James Simpson
Status: Merged
Approved by: Loïc Gomez
Approved revision: c1814d3b11a01fdbb85669594684000dc0b8280b
Merged at revision: 196e4059f9e211aa5693c037619ef0ded3e75bb1
Proposed branch: ~jsimpso/prometheus-pushgateway-snap:master
Merge into: prometheus-pushgateway-snap:master
Diff against target: 145 lines (+96/-17)
4 files modified
.gitignore (+9/-2)
README.md (+14/-2)
daemon_arguments (+23/-13)
prometheus_software_logo.svg (+50/-0)
Reviewer Review Type Date Requested Status
Loïc Gomez +1 Approve
Review via email: mp+429091@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Loïc Gomez (kotodama) :
review: Approve (+1)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/.gitignore b/.gitignore
2index bb3615c..3039f38 100644
3--- a/.gitignore
4+++ b/.gitignore
5@@ -1,5 +1,12 @@
6-/*.snap
7+# https://github.com/snapcrafters/fork-and-rename-me/blob/master/.gitignore
8 /parts/
9 /stage/
10 /prime/
11-/snap/
12+
13+*.snap
14+
15+.snapcraft
16+__pycache__
17+*.pyc
18+*_source.tar.bz2
19+snap/.snapcraft
20\ No newline at end of file
21diff --git a/README.md b/README.md
22index d8cc348..27325be 100644
23--- a/README.md
24+++ b/README.md
25@@ -1,3 +1,15 @@
26-# TODO
27+## Install
28+
29+ sudo snap install prometheus-pushgateway
30+
31+## Configure
32+
33+Check the status:
34+ systemctl status snap.prometheus-pushgateway.service
35+
36+Review and set any required daemon arguments:
37+ cat /var/snap/prometheus-pushgateway/current/daemon_arguments
38+
39+Restart pushgateway:
40+ systemctl restart snap.prometheus-pushgateway.pushgateway.service
41
42-We need a way to configure pushgateway. Possibly using /etc/default/prometheus-pushgateway style config shipped with the snap
43diff --git a/daemon_arguments b/daemon_arguments
44index 6627aa0..5fc5147 100644
45--- a/daemon_arguments
46+++ b/daemon_arguments
47@@ -1,17 +1,27 @@
48 # Set the command-line arguments to pass to the server.
49 ARGS=""
50
51+#############################################################################
52+# WARNING: Due to snap confinement the following options should not be set: #
53+#############################################################################
54+# --web.config.file="" [EXPERIMENTAL] Path to configuration file that can enable TLS or authentication.
55+
56 # The following options may be set:
57-# -persistence.file string
58-# File to persist metrics. If empty, metrics are only kept in memory.
59-# WARNINIG: due to snap confinement path should be prefixed with
60-# $SNAP_DATA for example: -persistence.file $SNAP_DATA/pushgateway.persist
61-# -log.level value
62-# Only log messages with the given severity or above. Valid levels: [debug, info, warn, error, fatal, panic].
63-# (default info)
64-# -persistence.interval duration
65-# The minimum interval at which to write out the persistence file. (default 5m0s)
66-# -web.listen-address string
67-# Address to listen on for the web interface, API, and telemetry. (default ":9091")
68-# -web.telemetry-path string
69-# Path under which to expose metrics. (default "/metrics")
70+# --web.listen-address=":9091"
71+# Address to listen on for the web interface, API, and telemetry.
72+# --web.telemetry-path="/metrics"
73+# Path under which to expose metrics.
74+# --web.external-url= The URL under which the Pushgateway is externally reachable.
75+# --web.route-prefix="" Prefix for the internal routes of web endpoints. Defaults to the path of --web.external-url.
76+# --web.enable-lifecycle Enable shutdown via HTTP request.
77+# --web.enable-admin-api Enable API endpoints for admin control actions.
78+# --persistence.file string
79+# File to persist metrics. If empty, metrics are only kept in memory.
80+# WARNINIG: due to snap confinement path should be prefixed with
81+# ${SNAP_DATA} for example: -persistence.file ${SNAP_DATA}/pushgateway.persist
82+#
83+# --persistence.interval=5m The minimum interval at which to write out the persistence file.
84+# --push.disable-consistency-check
85+# Do not check consistency of pushed metrics. DANGEROUS.
86+# --log.level=info Only log messages with the given severity or above. One of: [debug, info, warn, error]
87+# --log.format=logfmt Output format of log messages. One of: [logfmt, json]
88\ No newline at end of file
89diff --git a/prometheus_software_logo.svg b/prometheus_software_logo.svg
90new file mode 100644
91index 0000000..831514e
92--- /dev/null
93+++ b/prometheus_software_logo.svg
94@@ -0,0 +1,50 @@
95+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
96+<!-- Generator: Adobe Illustrator 16.0.0, SVG Export Plug-In . SVG Version: 6.00 Build 0) -->
97+
98+<svg
99+ xmlns:dc="http://purl.org/dc/elements/1.1/"
100+ xmlns:cc="http://creativecommons.org/ns#"
101+ xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
102+ xmlns:svg="http://www.w3.org/2000/svg"
103+ xmlns="http://www.w3.org/2000/svg"
104+ xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
105+ xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
106+ version="1.1"
107+ id="Layer_1"
108+ x="0px"
109+ y="0px"
110+ width="114px"
111+ height="114px"
112+ viewBox="0 0 115.333 114"
113+ enable-background="new 0 0 115.333 114"
114+ xml:space="preserve"
115+ sodipodi:docname="prometheus_logo_orange.svg"
116+ inkscape:version="0.92.1 r15371"><metadata
117+ id="metadata4495"><rdf:RDF><cc:Work
118+ rdf:about=""><dc:format>image/svg+xml</dc:format><dc:type
119+ rdf:resource="http://purl.org/dc/dcmitype/StillImage" /><dc:title></dc:title></cc:Work></rdf:RDF></metadata><defs
120+ id="defs4493" /><sodipodi:namedview
121+ pagecolor="#ffffff"
122+ bordercolor="#666666"
123+ borderopacity="1"
124+ objecttolerance="10"
125+ gridtolerance="10"
126+ guidetolerance="10"
127+ inkscape:pageopacity="0"
128+ inkscape:pageshadow="2"
129+ inkscape:window-width="1484"
130+ inkscape:window-height="886"
131+ id="namedview4491"
132+ showgrid="false"
133+ inkscape:zoom="5.2784901"
134+ inkscape:cx="60.603667"
135+ inkscape:cy="60.329656"
136+ inkscape:window-x="54"
137+ inkscape:window-y="7"
138+ inkscape:window-maximized="0"
139+ inkscape:current-layer="Layer_1" /><g
140+ id="Layer_2" /><path
141+ style="fill:#e6522c;fill-opacity:1"
142+ inkscape:connector-curvature="0"
143+ id="path4486"
144+ d="M 56.667,0.667 C 25.372,0.667 0,26.036 0,57.332 c 0,31.295 25.372,56.666 56.667,56.666 31.295,0 56.666,-25.371 56.666,-56.666 0,-31.296 -25.372,-56.665 -56.666,-56.665 z m 0,106.055 c -8.904,0 -16.123,-5.948 -16.123,-13.283 H 72.79 c 0,7.334 -7.219,13.283 -16.123,13.283 z M 83.297,89.04 H 30.034 V 79.382 H 83.298 V 89.04 Z M 83.106,74.411 H 30.186 C 30.01,74.208 29.83,74.008 29.66,73.802 24.208,67.182 22.924,63.726 21.677,60.204 c -0.021,-0.116 6.611,1.355 11.314,2.413 0,0 2.42,0.56 5.958,1.205 -3.397,-3.982 -5.414,-9.044 -5.414,-14.218 0,-11.359 8.712,-21.285 5.569,-29.308 3.059,0.249 6.331,6.456 6.552,16.161 3.252,-4.494 4.613,-12.701 4.613,-17.733 0,-5.21 3.433,-11.262 6.867,-11.469 -3.061,5.045 0.793,9.37 4.219,20.099 1.285,4.03 1.121,10.812 2.113,15.113 C 63.797,33.534 65.333,20.5 71,16 c -2.5,5.667 0.37,12.758 2.333,16.167 3.167,5.5 5.087,9.667 5.087,17.548 0,5.284 -1.951,10.259 -5.242,14.148 3.742,-0.702 6.326,-1.335 6.326,-1.335 l 12.152,-2.371 c 10e-4,-10e-4 -1.765,7.261 -8.55,14.254 z" /></svg>
145\ No newline at end of file

Subscribers

People subscribed via source and target branches