Merge ~jsimpso/charm-prometheus-alertmanager:master into charm-prometheus-alertmanager:master

Proposed by James Simpson
Status: Merged
Approved by: Eric Chen
Approved revision: 3b04dbc8b892349ca2c90a972f06207cb8693912
Merged at revision: 3a934be68001fdc96fea97a1aed6ae83cd1a9fe6
Proposed branch: ~jsimpso/charm-prometheus-alertmanager:master
Merge into: charm-prometheus-alertmanager:master
Diff against target: 9 lines (+2/-0)
1 file modified
src/wheelhouse.txt (+2/-0)
Reviewer Review Type Date Requested Status
Ramesh Sattaru (community) Approve
Erhan Sunar (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Review via email: mp+434468@code.launchpad.net

Commit message

Pin MarkupSafe<2.1.0 for bug LP:1999356

To post a comment you must log in.
Revision history for this message
James Simpson (jsimpso) wrote :

Deploying the current latest/edge charm results in the following error per the linked bug report:

2022-12-12 03:30:10 WARNING unit.alertmanager/0.upgrade-charm logger.go:60 ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/var/lib/juju/agents/unit-alertmanager-0/.venv/lib/python3.8/site-packages/markupsafe/__init__.py)

Deploying a locally built version of the charm with the included fix works without issue:

Model Controller Cloud/Region Version SLA Timestamp Notes
controller kif localhost/localhost 2.9.35 unsupported 11:43:43+08:00 upgrade available: 2.9.37

App Version Status Scale Charm Channel Rev Exposed Message
alertmanager active 1 prometheus-alertmanager 1 no Ready
prometheus-alertmanager error 1 prometheus-alertmanager edge 23 no hook failed: "alertmanager-cluster-relation-created"
prometheus-mongodb-exporter stable active 1 prometheus-mongodb-exporter 25 no
ubuntu 20.04 active 1 ubuntu stable 21 no

Unit Workload Agent Machine Public address Ports Message
alertmanager/1* active idle 3 192.168.20.64 9093/tcp Ready
prometheus-alertmanager/0* error idle 1 192.168.20.207 hook failed: "alertmanager-cluster-relation-created"
ubuntu/1* active idle 0 192.168.20.62
  prometheus-mongodb-exporter/22* active idle 192.168.20.62 19091/tcp

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Erhan Sunar (esunar) :
review: Approve
Revision history for this message
Ramesh Sattaru (rameshcan) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 3a934be68001fdc96fea97a1aed6ae83cd1a9fe6

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/wheelhouse.txt b/src/wheelhouse.txt
2index 86d690c..62fc47c 100644
3--- a/src/wheelhouse.txt
4+++ b/src/wheelhouse.txt
5@@ -1,2 +1,4 @@
6 # https://github.com/juju-solutions/layer-basic/issues/210
7 Jinja2<3.0;python_version == '3.8'
8+MarkupSafe<2.1.0;python_version >= '3.6' and python_version <= '3.8' # py36 bionic, py38 focal
9+MarkupSafe;python_version > '3.8'

Subscribers

People subscribed via source and target branches

to all changes: