Merge lp:~jshepher/nova/nova_manage_config_list into lp:~hudson-openstack/nova/trunk

[Justin Shepherd]

Added 'config list' to nova-manage. This function will output all of the flags and their values.

# ./bin/nova-manage config list
--storage_availability_zone=nova
--ca_file=cacert.pem
--ec2_dmz_host=$my_ip
--fixed_range=10.0.0.0/8
--compute_topic=compute
--dmz_mask=255.255.255.0
****SNIP****

I also alphabetized the nova-manage category listing

[Devin Carlen (devcamcar)]

nice!

review: Approve

[Vish Ishaya (vishvananda)]

hmm, I wonder about changing this slightly...

--help prints all of the flags with descriptions nicely categorized with default values
--helpxml prints in xml the same thing + the current value of the flag

We could pretty easily override --help to add the current value of the flag which might be a little nicer than that format?

[Justin Shepherd (jshepher)]

--help might get a bit hard to read with all the defaults, value types, and current values.. but let me know if that is the way I should go with this.

the other option.. is to not use the string format "--dmz_mask=255.255.255.0" but to use key:value (dmz_mask: 255.255.255.0)

[Justin Shepherd (jshepher)]

however, in the spirit of the example postconf.. it is nice for an administrator to have a function that just spits out all of the configuration paramaters with out any descriptions or defaults.. this is very nice when you just want to grep the running config for something:

Example:

# ./bin/nova-manage config list | grep -i glance
--glance_port=9292
--glance_host=$my_ip

# ./bin/nova-manage --help | grep -A2 -i glance
  --glance_host: glance host
    (default: '$my_ip')
  --glance_port: glance port
    (default: '9292')
    (an integer)

[Vish Ishaya (vishvananda)]

ok. I buy that rationale.

review: Approve

=== modified file 'bin/nova-manage'
--- bin/nova-manage	2011-06-03 15:11:01 +0000
+++ bin/nova-manage	2011-06-03 18:23:23 +0000
@@ -1081,24 +1081,35 @@
         self._convert_images(machine_images)
 
 
+class ConfigCommands(object):
+    """Class for exposing the flags defined by flag_file(s)."""
+
+    def __init__(self):
+        pass
+
+    def list(self):
+        print FLAGS.FlagsIntoString()
+
+
 CATEGORIES = [
-    ('user', UserCommands),
     ('account', AccountCommands),
+    ('config', ConfigCommands),
+    ('db', DbCommands),
+    ('fixed', FixedIpCommands),
+    ('flavor', InstanceTypeCommands),
+    ('floating', FloatingIpCommands),
+    ('instance_type', InstanceTypeCommands),
+    ('image', ImageCommands),
+    ('network', NetworkCommands),
     ('project', ProjectCommands),
     ('role', RoleCommands),
+    ('service', ServiceCommands),
     ('shell', ShellCommands),
-    ('vpn', VpnCommands),
-    ('fixed', FixedIpCommands),
-    ('floating', FloatingIpCommands),
-    ('network', NetworkCommands),
+    ('user', UserCommands),
+    ('version', VersionCommands),
     ('vm', VmCommands),
-    ('service', ServiceCommands),
-    ('db', DbCommands),
     ('volume', VolumeCommands),
-    ('instance_type', InstanceTypeCommands),
-    ('image', ImageCommands),
-    ('flavor', InstanceTypeCommands),
-    ('version', VersionCommands)]
+    ('vpn', VpnCommands)]
 
 
 def lazy_match(name, key_value_tuples):