Merge lp:~jshepher/nova/lp850289 into lp:~hudson-openstack/nova/trunk

Proposed by Justin Shepherd
Status: Needs review
Proposed branch: lp:~jshepher/nova/lp850289
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
bin/nova-manage (+1/-0)
To merge this branch: bzr merge lp:~jshepher/nova/lp850289
Reviewer Review Type Date Requested Status
Vish Ishaya (community) Disapprove
Review via email:

Description of the change

Imported nova/ to add the flags defined in that file into the "nova-manage --help" output.

To post a comment you must log in.
Revision history for this message
Vish Ishaya (vishvananda) wrote :

why do we need those flags in nova_manage --help? They aren't used by nova-manage.

review: Needs Information
Revision history for this message
Justin Shepherd (jshepher) wrote :

Mostly, from a sysadmin point of view.. the most common way to figure out what flags to populate your nova.conf file with is to run "nova-manage --help".


Revision history for this message
Vish Ishaya (vishvananda) wrote :

hmm. I don't think this is the right approach. Nova-manage will not bring in any flags from dynamically loaded extensions, etc. Importing a module that is not used will give a pylint error. The proper way to pull in other flags if you don't need to import the file is with flags.DECLARE, but since the flags aren't actually used I'm not so sure that is right either. Perhaps we could have a nova-manage flags command that would try to import every file in the tree and then print --help?

review: Disapprove
Revision history for this message
Justin Shepherd (jshepher) wrote :

Vish, I can definitely agree that this might not be the best way to solve this problem.

I am just not sure what the right way is.. in a normal situation i think the correct way would be a man file for nova.conf that contains definitions of all the flags, and their default values. But i think the codebase is moving too quickly for this to stay current.

Unmerged revisions

1575. By Justin Shepherd

imported nova/ to include defined flags

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/nova-manage'
2--- bin/nova-manage 2011-09-11 12:57:05 +0000
3+++ bin/nova-manage 2011-09-15 19:11:26 +0000
4@@ -84,6 +84,7 @@
5 from nova import log as logging
6 from nova import quota
7 from nova import rpc
8+from nova import service
9 from nova import utils
10 from nova import version
11 from nova import vsa