Merge lp:~jshepher/nova/lp780276 into lp:~hudson-openstack/nova/trunk

Proposed by Justin Shepherd
Status: Merged
Approved by: Paul Voccio
Approved revision: 1062
Merged at revision: 1063
Proposed branch: lp:~jshepher/nova/lp780276
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 20 lines (+2/-0)
2 files modified
Authors (+1/-0)
tools/pip-requires (+1/-0)
To merge this branch: bzr merge lp:~jshepher/nova/lp780276
Reviewer Review Type Date Requested Status
Paul Voccio (community) Approve
Ed Leafe (community) Approve
Jay Pipes (community) Approve
Review via email: mp+60448@code.launchpad.net

Commit message

Fix for #780276 (run_tests.sh fails test_authors_up_to_date when using git repo)

Description of the change

Bug Message:

run_tests.sh fails test_authors_up_to_date when using git repo

Error Message:

======================================================================
ERROR: test_authors_up_to_date (nova.tests.test_misc.ProjectTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/nova-bzr/trunk/nova/tests/test_misc.py", line 57, in test_authors_up_to_date
    import git
ImportError: No module named git

----------------------------------------------------------------------

Steps to reproduce error:

# git clone https://github.com/openstack/nova.git /opt/nova
# cd /opt/nova
# python tools/install_venv.py
# source .nova-venv/bin/activate
# ./run_tests.sh

Proposed Solution:

Added GitPython to [install_dir]/tools/pip-requires.

To post a comment you must log in.
Revision history for this message
Jay Pipes (jaypipes) wrote :

lgtm.

btw, Justin, this:

./run_tests.sh -V

is a shortcut for:

# python tools/install_venv.py
# source .nova-venv/bin/activate
# ./run_tests.sh

Cheers!
jay

review: Approve
Revision history for this message
Ed Leafe (ed-leafe) wrote :

lgtm

review: Approve
Revision history for this message
Paul Voccio (pvo) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Authors'
2--- Authors 2011-05-06 18:12:33 +0000
3+++ Authors 2011-05-10 03:47:23 +0000
4@@ -44,6 +44,7 @@
5 Josh Kleinpeter <josh@kleinpeter.org>
6 Joshua McKenty <jmckenty@gmail.com>
7 Justin Santa Barbara <justin@fathomdb.com>
8+Justin Shepherd <jshepher@rackspace.com>
9 Kei Masumoto <masumotok@nttdata.co.jp>
10 Ken Pepple <ken.pepple@gmail.com>
11 Kevin Bringard <kbringard@attinteractive.com>
12
13=== modified file 'tools/pip-requires'
14--- tools/pip-requires 2011-05-06 18:23:51 +0000
15+++ tools/pip-requires 2011-05-10 03:47:23 +0000
16@@ -33,3 +33,4 @@
17 suds==0.4
18 coverage
19 nosexcover
20+GitPython