Merge lp:~jseutter/lp2kanban/description-too-long into lp:~launchpad/lp2kanban/trunk

[Jerry Seutter]

Leankit appears to have a limitation on card description size of just under 20,000 characters. When bugs2cards tries to save a card with a larger description an error is thrown and the script fails. The Launchpad bug description should be truncated to avoid this situation.

[Chad Smith (chad.smith)]

This branch has been resubmitted shepherded into lp:~landscape/lp2kanban/landscape-deploy. We can close this request against lp:lp2kanban

review: Disapprove

Unmerged revisions

90. By Jerry Seutter on 2013-08-14

Truncate description length when too long for Leankit.

=== modified file 'src/lp2kanban/bugs2cards.py'
--- src/lp2kanban/bugs2cards.py	2013-06-19 19:44:20 +0000
+++ src/lp2kanban/bugs2cards.py	2013-08-14 14:48:14 +0000
@@ -396,7 +396,8 @@
         print "    Creating card for bug %s in %s." % (bug.id, next_lane.title)
         card = next_lane.addCard()
         card.title = bug.title
-        card.description = bug.description
+        # Leankit empirically has a max description length of 19997 bytes
+        card.description = bug.description[:19500]
         card.external_card_id = str(bug.id)
         card.type_id = new_cardtype
         card.save()

=== modified file 'src/lp2kanban/kanban.py'
--- src/lp2kanban/kanban.py	2013-05-24 14:48:07 +0000
+++ src/lp2kanban/kanban.py	2013-08-14 14:48:14 +0000
@@ -106,7 +106,6 @@
             print "Error from kanban"
             pprint(resp)
             raise IOError('kanban error %d' % (resp.status_code))
-
         response = Record(json.loads(resp.content))
 
         if (handle_errors and

=== modified file 'src/lp2kanban/tests/test_bugs2cards.py'
--- src/lp2kanban/tests/test_bugs2cards.py	2013-04-08 12:50:46 +0000
+++ src/lp2kanban/tests/test_bugs2cards.py	2013-08-14 14:48:14 +0000
@@ -750,6 +750,24 @@
         [card] = board.cards
         self.assertEqual('incoming', card.lane.path)
 
+    def test_bug_with_long_description_truncated(self):
+        # Bug descriptions that exceed the 19997 character limit of a
+        # kanban card are truncated to 19500 bytes.
+        board = FauxBoard()
+        bug_lane = board.addLane('bugs')
+        project = FauxLaunchpadProject(
+            bug_tasks=[FauxBugTask(
+                           bug_id=42, title='Test bug',
+                           description='x' * 20000,
+                           tags=['kanban'])])
+        create_new_cards(board, project, 'kanban')
+        [card] = board.cards
+        self.assertEqual('Test bug', card.title)
+        self.assertEqual(19500, len(card.description))
+        self.assertEqual('42', card.external_card_id)
+        self.assertEqual(board.default_cardtype.id, card.type_id)
+        self.assertTrue(card.saved)
+
 
 class GroupsConfigTest(unittest.TestCase):