Merge lp:~jrrowe89/unity/fix-for-bug-718880 into lp:unity

Proposed by Jamie Rowe
Status: Merged
Merged at revision: 876
Proposed branch: lp:~jrrowe89/unity/fix-for-bug-718880
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
src/TrashLauncherIcon.cpp (+1/-1)
To merge this branch: bzr merge lp:~jrrowe89/unity/fix-for-bug-718880
Reviewer Review Type Date Requested Status
David Barth (community) Approve
Didier Roche-Tolomelli Approve
Review via email: mp+49969@code.launchpad.net

Description of the change

Changes the quick list menu for the trash icon to be positioned as others are.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks a lot for your patch. It looks good ;)

Before we merge it we need you to sign the Canonical contributer agreement. It's a quick, but necessary step to getting your code into the tree. Luckily you only need to sign it once and it will apply to all other Canonical project contributions you may make in the future. http://www.canonical.com/contributors Make sure to CC David Barth when you send it in.

review: Approve
Revision history for this message
Jamie Rowe (jrrowe89) wrote :

> Thanks a lot for your patch. It looks good ;)
>
> Before we merge it we need you to sign the Canonical contributer agreement.
> It's a quick, but necessary step to getting your code into the tree. Luckily
> you only need to sign it once and it will apply to all other Canonical project
> contributions you may make in the future.
> http://www.canonical.com/contributors Make sure to CC David Barth when you
> send it in.

Thanks, The email has been sent off. Now onto something a little more challlenging I think :)

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

excellent, merging, thanks for your work there! :)

Revision history for this message
David Barth (dbarth) wrote :

Jamie completed the (c) assignment process.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/TrashLauncherIcon.cpp'
2--- src/TrashLauncherIcon.cpp 2011-02-09 02:32:44 +0000
3+++ src/TrashLauncherIcon.cpp 2011-02-16 13:40:07 +0000
4@@ -113,7 +113,7 @@
5
6 int tip_x = _launcher->GetBaseWidth () + 1; //icon_x + icon_w;
7 nux::Point3 center = GetCenter ();
8- int tip_y = center.y;
9+ int tip_y = center.y+ _launcher->GetParent ()->GetGeometry ().y;
10 QuicklistManager::Default ()->ShowQuicklist (_quicklist, tip_x, tip_y);
11 nux::GetWindowCompositor ().SetAlwaysOnFrontWindow (_quicklist);
12 }