Merge lp:~jr/ubiquity/encryptcheckbox_fix into lp:ubiquity

Proposed by Jonathan Riddell
Status: Merged
Merged at revision: 5790
Proposed branch: lp:~jr/ubiquity/encryptcheckbox_fix
Merge into: lp:ubiquity
Diff against target: 139 lines (+60/-35) (has conflicts)
3 files modified
debian/changelog (+8/-0)
gui/qt/stepUserSetup.ui (+48/-35)
ubiquity/plugins/ubi-usersetup.py (+4/-0)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~jr/ubiquity/encryptcheckbox_fix
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+139485@code.launchpad.net

Description of the change

  * Change encrypt home question to checkbox and indent it under the login
    option to make it clear it is a sub question to the login option

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-12-10 16:35:33 +0000
3+++ debian/changelog 2012-12-12 15:21:23 +0000
4@@ -4,12 +4,20 @@
5 * Honour base-installer/kernel/altmeta when deciding which kernels to
6 install or keep installed.
7
8+<<<<<<< TREE
9 [ Dmitrijs Ledkovs ]
10 * Moving question dialog to use a glade ui file, made it non
11 "re-entrant" safe, i.e. it started to remember previous action area
12 buttons. The fix is to clear action area, all other parts of the
13 dialog are always reset with something fresh. (LP: #1087823)
14
15+=======
16+ [ Scott Kitterman ]
17+ * Change encrypt home question to checkbox and indent it under the login
18+ option to make it clear it is a sub question to the login option
19+ (LP: #1066225)
20+
21+>>>>>>> MERGE-SOURCE
22 -- Colin Watson <cjwatson@ubuntu.com> Thu, 06 Dec 2012 17:19:09 +0000
23
24 ubiquity (2.13.7) raring; urgency=low
25
26=== modified file 'gui/qt/stepUserSetup.ui'
27--- gui/qt/stepUserSetup.ui 2012-02-16 11:22:22 +0000
28+++ gui/qt/stepUserSetup.ui 2012-12-12 15:21:23 +0000
29@@ -509,41 +509,54 @@
30 </item>
31 <item>
32 <widget class="QWidget" name="widget_6" native="true">
33- <layout class="QGridLayout" name="gridLayout_8">
34- <property name="margin">
35- <number>2</number>
36- </property>
37- <item row="1" column="0" colspan="2">
38- <widget class="QRadioButton" name="login_encrypt">
39- <property name="text">
40- <string>Require Password and decrypt home to login</string>
41- </property>
42- <property name="checked">
43- <bool>false</bool>
44- </property>
45- </widget>
46- </item>
47- <item row="0" column="1">
48- <widget class="QRadioButton" name="login_auto">
49- <property name="text">
50- <string>Log in Automatically</string>
51- </property>
52- <property name="checked">
53- <bool>false</bool>
54- </property>
55- </widget>
56- </item>
57- <item row="0" column="0">
58- <widget class="QRadioButton" name="login_pass">
59- <property name="text">
60- <string>Require my password to log in</string>
61- </property>
62- <property name="checked">
63- <bool>true</bool>
64- </property>
65- </widget>
66- </item>
67- </layout>
68+ <widget class="QCheckBox" name="login_encrypt">
69+ <property name="geometry">
70+ <rect>
71+ <x>27</x>
72+ <y>27</y>
73+ <width>291</width>
74+ <height>21</height>
75+ </rect>
76+ </property>
77+ <property name="text">
78+ <string>Require Password and decrypt home to login</string>
79+ </property>
80+ <property name="checked">
81+ <bool>false</bool>
82+ </property>
83+ </widget>
84+ <widget class="QRadioButton" name="login_auto">
85+ <property name="geometry">
86+ <rect>
87+ <x>346</x>
88+ <y>2</y>
89+ <width>139</width>
90+ <height>21</height>
91+ </rect>
92+ </property>
93+ <property name="text">
94+ <string>Log in Automatically</string>
95+ </property>
96+ <property name="checked">
97+ <bool>false</bool>
98+ </property>
99+ </widget>
100+ <widget class="QRadioButton" name="login_pass">
101+ <property name="geometry">
102+ <rect>
103+ <x>2</x>
104+ <y>2</y>
105+ <width>193</width>
106+ <height>21</height>
107+ </rect>
108+ </property>
109+ <property name="text">
110+ <string>Require my password to log in</string>
111+ </property>
112+ <property name="checked">
113+ <bool>true</bool>
114+ </property>
115+ </widget>
116 </widget>
117 </item>
118 <item>
119
120=== modified file 'ubiquity/plugins/ubi-usersetup.py'
121--- ubiquity/plugins/ubi-usersetup.py 2012-11-27 06:02:43 +0000
122+++ ubiquity/plugins/ubi-usersetup.py 2012-12-12 15:21:23 +0000
123@@ -504,6 +504,7 @@
124 #self.page.password.textChanged[str].connect(self.on_password_changed)
125 #self.page.verified_password.textChanged[str].connect(
126 # self.on_verified_password_changed)
127+ self.page.login_pass.clicked[bool].connect(self.on_login_pass_clicked)
128
129 self.page.password_debug_warning_label.setVisible(
130 'UBIQUITY_DEBUG' in os.environ)
131@@ -562,6 +563,9 @@
132 def get_auto_login(self):
133 return self.page.login_auto.isChecked()
134
135+ def on_login_pass_clicked(self, checked):
136+ self.page.login_encrypt.setEnabled(checked)
137+
138 def set_encrypt_home(self, value):
139 self.page.login_encrypt.setChecked(value)
140

Subscribers

People subscribed via source and target branches

to status/vote changes: