Merge lp:~jr/launchpad/676825-most-neglected into lp:launchpad

[Jonathan Riddell]

[r=jcsackett][bug=676825] Changes the title for "least recently changed" to "most neglected"

For https://bugs.launchpad.net/launchpad/+bug/676825 the bug sort option "least recently changed" is considered confusing to read.

Proposed fix is to change it to "most neglected".

Testing, I have viewed the change on the page https://bugs.launchpad.dev/bazaar running on a local launchpad instance, search works correctly.

[Matthew Revell (matthew.revell)]

"Most neglected" seems like a good compromise. It doesn't communicate precisely how the search is ordered but I think this wording is easily understood and close enough to how the search is ordered.

review: Approve (text)

[j.c.sackett (jcsackett)]

review: Approve

=== modified file 'lib/lp/bugs/stories/bugtask-searches/xx-sort-orders.txt'
--- lib/lp/bugs/stories/bugtask-searches/xx-sort-orders.txt	2010-10-05 22:04:38 +0000
+++ lib/lp/bugs/stories/bugtask-searches/xx-sort-orders.txt	2011-06-27 15:16:39 +0000
@@ -59,10 +59,10 @@
     1 Firefox does not support SVG
     mozilla-firefox Low Confirmed
 
-By least recently changed:
+By most neglected:
 
     >>> anon_browser.getControl(name="orderby").displayValue = [
-    ...     "least recently changed"]
+    ...     "most neglected"]
     >>> anon_browser.getControl('Search', index=0).click()
     >>> print_bugtasks(anon_browser.contents)
     1 Firefox does not support SVG

=== modified file 'lib/lp/bugs/templates/bugtarget-macros-search.pt'
--- lib/lp/bugs/templates/bugtarget-macros-search.pt	2010-11-19 15:12:44 +0000
+++ lib/lp/bugs/templates/bugtarget-macros-search.pt	2011-06-27 15:16:39 +0000
@@ -53,7 +53,7 @@
     <option
       value="date_last_updated"
       tal:attributes="selected python:orderby == 'date_last_updated'"
-    >least recently changed</option>
+    >most neglected</option>
     <option
       value="-date_last_updated"
       tal:attributes="selected python:orderby == '-date_last_updated'"

=== modified file 'lib/lp/code/browser/branchlisting.py'
--- lib/lp/code/browser/branchlisting.py	2011-03-03 01:13:47 +0000
+++ lib/lp/code/browser/branchlisting.py	2011-06-27 15:16:39 +0000
@@ -306,7 +306,7 @@
         """)
 
     LEAST_RECENTLY_CHANGED_FIRST = Item("""
-        least recently changed first
+        most neglected first
 
         Sort branches from the least recently to the most recently
         changed.

=== modified file 'lib/lp/code/stories/branches/xx-branch-listings.txt'
--- lib/lp/code/stories/branches/xx-branch-listings.txt	2010-08-23 03:30:54 +0000
+++ lib/lp/code/stories/branches/xx-branch-listings.txt	2011-06-27 15:16:39 +0000
@@ -197,7 +197,7 @@
     >>> filter_control.displayOptions
     ['by project name', 'by status', 'by branch name',
     'by owner name', 'most recently changed first',
-    'least recently changed first', 'newest first', 'oldest first']
+    'most neglected first', 'newest first', 'oldest first']
 
 
 
@@ -277,7 +277,7 @@
     by status
     by branch name
     most recently changed first
-    least recently changed first
+    most neglected first
     newest first
     oldest first
 
@@ -300,7 +300,7 @@
     by branch name
     by owner name
     most recently changed first
-    least recently changed first
+    most neglected first
     newest first
     oldest first