Code review comment for lp:~jr/bzr/i18n-enable-translations-everywhere

Jonathan Riddell (jr) wrote :

Thanks for your support :)

This doesn't install gettext every time because install() returns immediately if it is already installed(). I think running install() within i18n.gettext() is preferable because it only does the gettext setup if it is needed, some commands won't need it so that would be a waste of process time.

Running "time bzr status" on an empty directly with gettext installed every times takes the real execution time from typically slightly below 0.1s to slightly above 0.1s so I think it's worth avoiding if possible.

« Back to merge proposal