Merge lp:~jpds/launchpad/fix_116279 into lp:launchpad

[Jonathan Davies]

On CD image mirror pages, list Ubuntu first and then derivatives.

[Jonathan Davies (jpds)]

= Summary =

On our CD image mirror pages, list the derivatives last and place Ubuntu first. Because these aren't in the DB, we have to and .sort() and then .reverse() them as they are read from the .manifest file.

[Henning Eggers (henninge)]

Thanks for this fix but looking at it I am missing a few things.

1. Did you have a pre-imp chat with some-one from the Launchpad team, preferrably the registry team? I am not sure this solution is ideal because Ubuntu will only be on top until someone comes up with "Zulubuntu" ... ;-)
2. Aren't any tests affected by the change? That would be surprising.
3. In any case, you'd need a test to verify that the order is now as expected.

Cheers,
Henning

review: Needs Fixing (code)

Unmerged revisions

10096. By Jonathan Davies on 2009-12-31

Sort CD image mirror flavours and then reverse the listing so that Ubuntu comes
first.

=== modified file 'lib/lp/registry/browser/distributionmirror.py'
--- lib/lp/registry/browser/distributionmirror.py	2009-12-12 22:15:31 +0000
+++ lib/lp/registry/browser/distributionmirror.py	2010-01-23 15:01:22 +0000
@@ -143,6 +143,8 @@
                 flavours_by_series = _FlavoursByDistroSeries(series, [])
                 all_series[series] = flavours_by_series
             flavours_by_series.flavours.append(flavour)
+            flavours_by_series.flavours.sort()
+            flavours_by_series.flavours.reverse()
         flavours_by_series = all_series.values()
         return sorted(flavours_by_series, reverse=True,
                       key=lambda item: Version(item.distroseries.version))