Code review comment for lp:~jpds/account-plugins/linkedin-plugin

Revision history for this message
Alberto Mardegan (mardy) wrote :

I've been now testing it with the new signon-ui, and it works well.

Just a couple of changes:

126 +UsernameField = input[name="email"]
127 +PasswordField = input[name="pass"]

Remove the password field, and change the username one to:

    UsernameField = input[name="session_key"]

Then, in the .provider file:

70 + <name> LinkedIn® </name>

Remove the spaces inside the element: they cause the label not to be properly left-aligned in the UI.

review: Needs Fixing

« Back to merge proposal