Merge lp:~jpakkane/unity/pch-experiment into lp:unity
Status: | Rejected |
---|---|
Rejected by: | Jussi Pakkanen |
Proposed branch: | lp:~jpakkane/unity/pch-experiment |
Merge into: | lp:unity |
Diff against target: |
169 lines (+114/-3) 5 files modified
CMakeLists.txt (+2/-0) UnityCore/CMakeLists.txt (+6/-2) UnityCore/FilesystemLenses.cpp (+1/-1) UnityCore/pch/unitycore_pch.hh (+33/-0) pch.cmake (+72/-0) |
To merge this branch: | bzr merge lp:~jpakkane/unity/pch-experiment |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity Team | Pending | ||
Review via email: mp+128467@code.launchpad.net |
Description of the change
Do NOT merge this code as is! It is only a proof of concept. It will compile and run but the end result will not work properly, because I had to change some definitions.
That being said, this patch adds support for GCC precompiled headers, which cuts down compile times quite nicely. To try it out, just check out and configure. Then run 'time make unity-core-6.0'. There is a CMake option for compiling with or without PCH. Just toggle that and run 'make clean' and then the previous command to compare build times.
On my machine building in debug mode without PCH takes 1m 50s. Enabling PCH drops that to 1 minute.
To get this merged, the build system needs a changes (which would be good even by themselves), enabling PCH for all targets and probably some general cleanup. None of these are massive tasks, though.
Changing to WIP so this MP doesn't sit in the review queue.