Code review comment for lp:~jpakkane/unity-notifications/simpleqml

Revision history for this message
Michael Zanetti (mzanetti) wrote :

132 - qmlRegisterUncreatableType<NotificationClient>(uri, 1, 0, "NotificationClient", "");
133 + qmlRegisterSingletonType<SimpleQmlSender>(uri, 1, 0, "unity.notifications", senderProvider);

Why this? QML types are supposed to be uppercase and the . is really confusing (if it works at all) because usually its the delimiter for named imports.

=====

I'd fancy a test :)

review: Needs Fixing

« Back to merge proposal