Merge lp:~jpakkane/indicator-network/virtualdestructors into lp:~unity-api-team/indicator-network/devel

[Jussi Pakkanen]

Added virtual destructors to base classes with virtual methods.

Added virtual destructors to base classes with virtual methods.

[lp:~jpakkane/indicator-network/virtualdestructors]

337. By Jussi Pakkanen on 2014-06-05

This one's for Charles.

[Antti Kaijanmäki (kaijanmaki)]

LGTM.

[Antti Kaijanmäki (kaijanmaki)]

review: Approve

=== modified file 'network/indicator-menu.h'
--- network/indicator-menu.h	2014-05-12 11:36:59 +0000
+++ network/indicator-menu.h	2014-06-05 14:12:36 +0000
@@ -60,6 +60,8 @@
         m_rootMenu->append(m_rootItem);
     }
 
+    virtual ~IndicatorMenu() {}
+
     virtual void
     addSection(Section::Ptr section)
     {

=== modified file 'network/menuitems/section.h'
--- network/menuitems/section.h	2014-04-24 13:24:05 +0000
+++ network/menuitems/section.h	2014-06-05 14:12:36 +0000
@@ -29,6 +29,8 @@
 public:
     typedef std::shared_ptr<Section> Ptr;
 
+    virtual ~Section() {}
+
     virtual ActionGroup::Ptr actionGroup() = 0;
     virtual MenuModel::Ptr   menuModel()   = 0;
 

=== modified file 'network/menumodel-cpp/menu-model.h'
--- network/menumodel-cpp/menu-model.h	2014-03-13 19:38:45 +0000
+++ network/menumodel-cpp/menu-model.h	2014-06-05 14:12:36 +0000
@@ -26,6 +26,7 @@
     typedef std::shared_ptr<MenuModel> Ptr;
 
     virtual operator GMenuModel*() = 0;
+    virtual ~MenuModel() {}
 };
 
 #endif