Merge lp:~jpakkane/indicator-network/quickexit into lp:indicator-network/15.04

Proposed by Antti Kaijanmäki
Status: Merged
Approved by: Antti Kaijanmäki
Approved revision: 449
Merged at revision: 461
Proposed branch: lp:~jpakkane/indicator-network/quickexit
Merge into: lp:indicator-network/15.04
Diff against target: 81 lines (+7/-7)
5 files modified
src/connectivity-cpp/src/manager.cpp (+1/-1)
src/connectivity-cpp/src/platform/nmofono/manager.cpp (+1/-1)
src/connectivity-cpp/src/platform/nmofono/wifi/link.cpp (+2/-2)
src/indicator/connectivity-service/connectivity-service.cpp (+1/-1)
src/indicator/modem-manager.cpp (+2/-2)
To merge this branch: bzr merge lp:~jpakkane/indicator-network/quickexit
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Antti Kaijanmäki (community) Approve
Review via email: mp+240403@code.launchpad.net

Commit message

Use std::quick_exit.

To post a comment you must log in.
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/connectivity-cpp/src/manager.cpp'
2--- src/connectivity-cpp/src/manager.cpp 2014-09-22 13:03:01 +0000
3+++ src/connectivity-cpp/src/manager.cpp 2014-11-03 08:44:45 +0000
4@@ -38,7 +38,7 @@
5 // If this happens, indicator-network is in an unknown state with no clear way of
6 // recovering. The only reasonable way out is a graceful exit.
7 std::cerr << __PRETTY_FUNCTION__ << " Failed to connect to managerinstance: " << e.what() << std::endl;
8- exit(0);
9+ std::quick_exit(0);
10 }
11 return mgr;
12 }
13
14=== modified file 'src/connectivity-cpp/src/platform/nmofono/manager.cpp'
15--- src/connectivity-cpp/src/platform/nmofono/manager.cpp 2014-10-09 10:58:30 +0000
16+++ src/connectivity-cpp/src/platform/nmofono/manager.cpp 2014-11-03 08:44:45 +0000
17@@ -104,7 +104,7 @@
18 // If this happens, indicator-network is in an unknown state with no clear way of
19 // recovering. The only reasonable way out is a graceful exit.
20 std::cerr << __PRETTY_FUNCTION__ << " Failed to run dbus service: " << e.what() << std::endl;
21- exit(0);
22+ std::quick_exit(0);
23 }
24 }));
25 location::set_name_for_thread(
26
27=== modified file 'src/connectivity-cpp/src/platform/nmofono/wifi/link.cpp'
28--- src/connectivity-cpp/src/platform/nmofono/wifi/link.cpp 2014-10-09 10:58:30 +0000
29+++ src/connectivity-cpp/src/platform/nmofono/wifi/link.cpp 2014-11-03 08:44:45 +0000
30@@ -183,7 +183,7 @@
31 // If this happens, indicator-network is in an unknown state with no clear way of
32 // recovering. The only reasonable way out is a graceful exit.
33 std::cerr << __PRETTY_FUNCTION__ << " Failed to run dbus service: " << e.what() << std::endl;
34- exit(0);
35+ std::quick_exit(0);
36 }
37 }
38
39@@ -399,7 +399,7 @@
40 // If this happens, indicator-network is in an unknown state with no clear way of
41 // recovering. The only reasonable way out is a graceful exit.
42 std::cerr << __PRETTY_FUNCTION__ << " Failed to activate connection: " << e.what() << std::endl;
43- exit(0);
44+ std::quick_exit(0);
45 }
46 }
47
48
49=== modified file 'src/indicator/connectivity-service/connectivity-service.cpp'
50--- src/indicator/connectivity-service/connectivity-service.cpp 2014-09-12 10:51:35 +0000
51+++ src/indicator/connectivity-service/connectivity-service.cpp 2014-11-03 08:44:45 +0000
52@@ -126,7 +126,7 @@
53 m_bus->run();
54 } catch(const std::exception &e) {
55 std::cerr << __PRETTY_FUNCTION__ << "dbus-cpp crashed: " << e.what() << "\n";
56- exit(0);
57+ std::quick_exit(0);
58 }
59 }));
60
61
62=== modified file 'src/indicator/modem-manager.cpp'
63--- src/indicator/modem-manager.cpp 2014-10-15 11:31:13 +0000
64+++ src/indicator/modem-manager.cpp 2014-11-03 08:44:45 +0000
65@@ -60,7 +60,7 @@
66 // If this happens, indicator-network is in an unknown state with no clear way of
67 // recovering. The only reasonable way out is a graceful exit.
68 std::cerr << __PRETTY_FUNCTION__ << " Failed to run dbus service: " << e.what() << std::endl;
69- exit(0);
70+ std::quick_exit(0);
71 }
72 }));
73
74@@ -200,7 +200,7 @@
75 // and reliable way to recover so die and get restarted.
76 // See also https://bugs.launchpad.net/unity-notifications/+bug/1238990
77 std::cerr << __PRETTY_FUNCTION__ << " sim unlocking failed: " << e.what() << "\n";
78- exit(0);
79+ std::quick_exit(0);
80 }
81 }
82

Subscribers

People subscribed via source and target branches