Merge lp:~jpakkane/frame/virtual-destructors into lp:frame

[Jussi Pakkanen]

Add virtual destructors to classes with virtual methods.

-Weffc++ produces still these kinds of errors, but they are for classes inherited from empty C structs, which won't be an issue.

No tests because this is a non-functionality bug.

[Chase Douglas (chasedouglas)]

Looks fine to me.

review: Approve

[Stephen M. Webb (bregma)]

I agree.

review: Approve

=== modified file 'src/v2/window.h'
--- src/v2/window.h	2012-01-11 15:56:42 +0000
+++ src/v2/window.h	2012-03-22 08:35:27 +0000
@@ -35,6 +35,7 @@
 class Window : public std::enable_shared_from_this<Window> {
  public:
   Window();
+  virtual ~Window() {};
 
   bool IsTouchOwned(UFTouchId touchid) const;
   void ReleaseFrames();

=== modified file 'src/v2/x11/window_x11.h'
--- src/v2/x11/window_x11.h	2012-01-11 15:56:42 +0000
+++ src/v2/x11/window_x11.h	2012-03-22 08:35:27 +0000
@@ -42,6 +42,7 @@
  public:
   WindowX11(::Window window, const SharedUFDevice& device,
             Display* display);
+  virtual ~WindowX11() {};
 
   bool HandleDeviceEvent(const XIDeviceEvent* event, SharedUFFrame* frame);
   bool HandleOwnershipEvent(const XITouchOwnershipEvent* event,