Merge lp:~jpakkane/dbus-cpp/depfix into lp:dbus-cpp

Proposed by Jussi Pakkanen
Status: Needs review
Proposed branch: lp:~jpakkane/dbus-cpp/depfix
Merge into: lp:dbus-cpp
Diff against target: 28 lines (+7/-4)
1 file modified
tests/CMakeLists.txt (+7/-4)
To merge this branch: bzr merge lp:~jpakkane/dbus-cpp/depfix
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+165314@code.launchpad.net

Commit message

Error out if dependencies are not found.

Description of the change

Error out if dependencies are not found.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

is this going to land?

Unmerged revisions

5. By Jussi Pakkanen

Break with an error immediately if dependencies are not found.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/CMakeLists.txt'
2--- tests/CMakeLists.txt 2013-05-21 09:49:21 +0000
3+++ tests/CMakeLists.txt 2013-05-23 09:09:29 +0000
4@@ -20,11 +20,11 @@
5 add_subdirectory(/usr/src/gtest gtest)
6 set (CMAKE_CXX_FLAGS ${OLD_CMAKE_CXX_FLAGS})
7
8-find_package(PkgConfig)
9-find_package(Boost COMPONENTS system)
10-find_package(Threads)
11+find_package(PkgConfig REQUIRED)
12+find_package(Boost COMPONENTS system REQUIRED)
13+find_package(Threads REQUIRED)
14
15-pkg_check_modules(DBUS dbus-1)
16+pkg_check_modules(DBUS dbus-1 REQUIRED)
17
18 option(
19 DBUS_CPP_ENABLE_DBUS_TEST_RUNNER
20@@ -34,6 +34,9 @@
21
22 if (DBUS_CPP_ENABLE_DBUS_TEST_RUNNER)
23 find_program(DBUS_TEST_RUNNER_EXECUTABLE dbus-test-runner)
24+ if(NOT DBUS_TEST_RUNNER_EXECUTABLE)
25+ message(FATAL_ERROR "Could not find dbus-test-runner executable.")
26+ endif()
27 message(STATUS "Executing test suite under dbus-test-runner")
28 endif (DBUS_CPP_ENABLE_DBUS_TEST_RUNNER)
29

Subscribers

People subscribed via source and target branches